[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-datatype-cvs
Subject: [Datatype-cvs] omx/common CBaseOmxDec.cpp,1.1.2.12,1.1.2.13
From: xzhao () helixcommunity ! org
Date: 2010-11-29 1:43:05
Message-ID: 201011290143.oAT1hCdA020387 () mailer ! progressive-comp ! com
[Download RAW message or body]
Update of /cvsroot/datatype/omx/common
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv809
Modified Files:
Tag: hxclient_3_1_0_atlas
CBaseOmxDec.cpp
Log Message:
> Bug Number: 12182
>
> Synopsis: On Qualcomm platform, use libstagefright to play flash and pause it, use \
> Helix to HW play any clips, then turn back to flash playing, it will crash.
> Overview: Once Helix HW playing any clips, it call OMX_Deinit() in Close() \
> function. However, on Qualcomm platform, it will also free the libstagefight's play \
> resource because of this function calling(such as handler), so once flash resume, \
> it will crash, since currently libstagefright do not release its OMX resource when \
> it is being paused. In order to not crash libstagefright now, we need to remove \
> this calling.
> Files Modified:
> datatype/omx/common/CBaseOmxDec.cpp
Index: CBaseOmxDec.cpp
===================================================================
RCS file: /cvsroot/datatype/omx/common/CBaseOmxDec.cpp,v
retrieving revision 1.1.2.12
retrieving revision 1.1.2.13
diff -u -d -r1.1.2.12 -r1.1.2.13
--- CBaseOmxDec.cpp 15 Nov 2010 09:16:18 -0000 1.1.2.12
+++ CBaseOmxDec.cpp 29 Nov 2010 01:43:02 -0000 1.1.2.13
@@ -279,7 +279,10 @@
// now we can free the component handle
OMX_FreeHandle(m_hDecoder);
m_hDecoder = NULL;
+#ifndef ANDROID
+ /* On Qualcomm platform, this calling will also free other engine applied OMX \
core play resource(such as handler), so once flash(libstagefright) resume, it will \
crash, since currently libstagefright do not release its OMX resource when it is \
being paused. */ OMX_Deinit();
+#endif
if (ret != OMX_ErrorNone)
{
return HXR_FAIL;
_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic