[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs]
From:       joeli () helixcommunity ! org
Date:       2010-11-26 2:09:02
Message-ID: 201011260209.oAQ29885011395 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/datatype/mkv/fileformat
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv3967

Modified Files:
      Tag: hxclient_3_6_2_atlas
	mkv_file_format.cpp 
Log Message:
Modified by: joeli@real.com
Date: 2010-11-25
Project: RealPlayer for Android Smartphones
Bug Number: 11192

Overview:
for some broken contents, when mkv file format parsed the file header, \
KaxContentCompSettings fetched null data. If you still GetSize from that data, it \
will crash. So we need to return fail and tell client the file is invalid.

Files Added:
NA

Files Modified:
datatype/mkv/fileformat/mkv_file_format.cpp
datatype/mkv/libmatroska/Matroska.cpp

Image Size and Heap Use impact (Client-Only):
None

Platforms and Profiles Affected:
Platform: hxclient_3_6_2_atlas & hxclient_3_6_1_atlas
Profile: helix-client-android and helix-client-all-defines

Distribution Libraries Affected:
NA

Distribution library impact and planned action:
NA

Platforms and Profiles Build Verified:
Platform: hxclient_3_6_2_atlas  & hxclient_3_6_1_atlas
Profile:  helix-client-android and helix-client-all-defines

Platforms and Profiles Functionality verified:
Platform: hxclient_3_6_2_atlas & hxclient_3_6_1_atlas
Profile: helix-client-android and helix-client-all-defines

Branch: hxclient_3_6_2_atlas & hxclient_3_6_1_atlas
Copyright assignment: I am a RealNetworks employee


Index: mkv_file_format.cpp
===================================================================
RCS file: /cvsroot/datatype/mkv/fileformat/mkv_file_format.cpp,v
retrieving revision 1.1.1.1.2.1.12.2
retrieving revision 1.1.1.1.2.1.12.3
diff -u -d -r1.1.1.1.2.1.12.2 -r1.1.1.1.2.1.12.3
--- mkv_file_format.cpp	25 Nov 2010 02:38:42 -0000	1.1.1.1.2.1.12.2
+++ mkv_file_format.cpp	26 Nov 2010 02:08:59 -0000	1.1.1.1.2.1.12.3
@@ -389,6 +389,7 @@
 		{
 			HXLOGL1(HXLOG_MKVF, "CMKVFileFormat::GetFileHeader(): Invalid File!");
 			retVal = HXR_INVALID_FILE;
+			m_pFormatResponse->FileHeaderReady(retVal, NULL);
 		}
 	}
 


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs


[prev in list] [next in list] [prev in thread] [next in thread]