[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs] mp4/audio/renderer mp4afmt.cpp, 1.27.2.2.26.1,
From:       sblanding () helixcommunity ! org
Date:       2010-05-28 22:10:50
Message-ID: 201005282211.o4SMB6jR028226 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/datatype/mp4/audio/renderer
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv4842

Modified Files:
      Tag: bainbridge
	mp4afmt.cpp 
Log Message:
Don't reduce the size of our audio buffer as conditions change.
Doing so is unnecessary and a slight performance hit.
Fixing this also fixes a category of bugs where the decoder tells us
conditions have changed such that we can reduce our buffer size but 
it writes to the old buffer size anyway.
See PR#256102 and 259179.


Index: mp4afmt.cpp
===================================================================
RCS file: /cvsroot/datatype/mp4/audio/renderer/mp4afmt.cpp,v
retrieving revision 1.27.2.2.26.1
retrieving revision 1.27.2.2.26.1.2.1
diff -u -d -r1.27.2.2.26.1 -r1.27.2.2.26.1.2.1
--- mp4afmt.cpp	29 Jul 2009 18:13:24 -0000	1.27.2.2.26.1
+++ mp4afmt.cpp	28 May 2010 22:10:47 -0000	1.27.2.2.26.1.2.1
@@ -492,8 +492,8 @@
         // Allocate Decoder Buffer
         if (SUCCEEDED(retVal))
         {
-            // Did the size change?
-            if (m_ulDecoderBufferSize != m_ulMaxDecoderOutputBytes)
+            // Do we need a larger buffer?
+            if (m_ulDecoderBufferSize < m_ulMaxDecoderOutputBytes)
             {
                 retVal = HXR_OUTOFMEMORY;
                 HX_VECTOR_DELETE(m_pDecoderBuffer);


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs
[prev in list] [next in list] [prev in thread] [next in thread]