[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-datatype-cvs
Subject: [Datatype-cvs] tools/metadataeng/utility/platform/symbian
From: asheesh () helixcommunity ! org
Date: 2009-12-23 22:55:37
Message-ID: 200912232255.nBNMtsJB026576 () mailer ! progressive-comp ! com
[Download RAW message or body]
Update of /cvsroot/datatype/tools/metadataeng/utility/platform/symbian
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv14380
Modified Files:
Tag: hxclient_4_2_0_brizo
hxtnutil_impl.cpp
Log Message:
Merged 64 Bit, AVi 2.0 and Dolby Digital features and a thumbnail engine fix to \
Brizo_420 branch.
-----------------------------------------------------------------------------------------------------------------------------
Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."
Modified by: ext-dushyant.vipradas@nokia.com
Reviewed by:
Date: 21-Dec-2009
Project: symbianMmf_wm
TSW-Id: EJVZ-7XR35B
Synergy id: ou1cimx1#195516
Synopsis: RealPlayer video play freeze for a while
Overview: The 64 bit asynchronous service request 'read' issued by \
CHXDataSourceCContent::Read on Cdata::Read was taking exceptionally long time to \
complete. This added delay resulted in dry buffers which in turn resulted in \
frequent rebuffering which caused the video to freeze for a while. The priority of \
CHXAudioDevice's active object was set to 'EPriorityHigh' and hence was taking \
precedence over the CHXDataSourceCContent's service request. Changing the priority \
of CHXAudioDevice from EPriorityHigh to EPriorityStandard allows \
CHXDataSourceCContent's request to complete faster.
Files Modified:
T:\HxArm\audio\device\platform\symbian\audsymbian.cpp
Image Size and Heap Use impact: none
Module Release testing (STIF): Yes.
Test case(s) Added: none
Memory leak check performed: Yes, no new leaks introduced.
Platforms and Profiles Build Verified:
armv5,winscw / helix-client-s60-52-mmf-mdf-dsp
Branch:
420_Brizo
-----------------------------------------------------------------------------------------------------------------------------
"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."
Modified by: yury.ramanovich@nokia.com, dushyant.vipradas@nokia.com
Reviewed by:
Date: 12/16/2009
Project: SymbianMmf_wm
ErrorId: CPHU-7YMRTM, ou1cimx1#218155
Synopsis: crash during AVI file playback
Overview: AVI stream index was not set (NULL) for AVI v1.0 files, which lead to crash \
during CAVIIndex::GetMaxChunkSize()
Solution: set AVI stream index for all AVI v1.0 files
Files Added:
None.
Files Modified:
datatype/avi/fileformat/aviffpln.cpp
Image Size and Heap Use impact: minor
Module Release testing (STIF) : MRT subset
Test case(s) Added : No.
Memory leak check performed : Yes. No new leaks introduced
Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-dsp
helix-client-s60-52-mmf-mdf-dsp
Platforms and Profiles Functionality verified: armv5, winscw
Branch: cay210, brizo420, HEAD
-----------------------------------------------------------------------------------------------------------------------------
"Nokia submits this code under the terms of a commercial contribution agreement with \
Real Networks, and I am authorized to contribute this code under said agreement."
Modified by: ext-gabriela.valverde@nokia.com
Reviewed by:
Date: 14/10/2009
Project: SymbianMmf_wm
Synopsis: 64-bit offset support in mp4/3gp file format for file sizes > 4GB
Overview:
These changes add support for mp4/3gp files that contain atoms/boxes with 64-bit \
extended size and co64 atom(s). Previously, the 64-bit extended size syntax was \
already supported, so files that made use of it were parsed correctly but they were \
only playable if the atom size did not exceed 2^32 (4GB). The specific changes are:
- Allowing atoms with sizes greater than 4GB (making use of the full 64 bits of \
extended size in the atom/box header)
- Adding support for 64-bit offset values in co64 chunk offset table
A bug in the GetUL64 routine (CQTAtom class) for reading 64-bit values is also \
corrected. The lower 32-bits need to be type-casted to an unsigned type, otherwise \
the compiler generated code that made use of sign-extension instructions, which \
caused the upper 32 bits to be incorrectly set to 1 for values in the range \
0x00000000 800000000 to 0x00000000 F0000000 (so the return values were 0xFFFFFFFF \
800000000 - 0xFFFFFFFF F0000000 before the fix). Files modified:
datatype\mp4\fileformat\atomizer.cpp
datatype\mp4\fileformat\fswtchr.cpp
datatype\mp4\fileformat\qtatoms.cpp
datatype\mp4\fileformat\qtbatom.cpp
datatype\mp4\fileformat\qttrack.cpp
datatype\mp4\fileformat\pub\atomizer.h
datatype\mp4\fileformat\pub\fswtchr.h
datatype\mp4\fileformat\pub\hxfswch.h
datatype\mp4\fileformat\pub\qtatmmgs.h
datatype\mp4\fileformat\pub\qtatoms.h
datatype\mp4\fileformat\pub\qtbatom.h
datatype\mp4\fileformat\pub\qttrack.h
Files added: None
Image Size and Heap Use impact: Moderate/High
Module Release testing (STIF) : In progress
Test case(s) Added : No
Memory leak check performed : In progress
Platforms and Profiles Build Verified: helix-client-s60-52-mmf-mdf-dsp
Platforms and Profiles Functionality verified: armv5, winscw
Branch: Brizo420
-----------------------------------------------------------------------------------------------------------------------------
"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."
Modified by: ext-dushyant.vipradas@nokia.com
Reviewed by:
Date: 11/27/2009
Project: SymbianMmf_wm
ErrorId: JRAH-7XXTAD
Overview: AVI 2.0 seek support is now extended to more than 1gb and we can seek to \
any location in the file.
Files Added:
None.
Files Modified:
\datatype\avi\fileformat\aviffpln.cpp
\datatype\avi\fileformat\avistrm.cpp
Image Size and Heap Use impact: minor
Module Release testing (STIF) : -
Test case(s) Added : No.
Platforms and Profiles Build Verified:
helix-client-s60-52-mmf-mdf-dsp
Platforms and Profiles Functionality verified: winscw, armv5
Branch: 420Brizo
-----------------------------------------------------------------------------------------------------------------------------
Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."
Modified by: Gang.Jia@nokia.com
Reviewed by:
Date: 11/6/2009
Project: SymbianMmf_wm
ErrorId: SUB 417-45841
Synopsis: CR: 417-45841 Helix support for Dolby Digital audio stereo playback
Helix support for Dolby Digital audio stereo playback including following:
- Support for Dolby Digital audio (AC-3) in AVI and Matroska file formats
- Decoding and playing of Dolby Digital audio (AC-3) contents using AC-3/EAC-3 codec \
with MMF HwDevice interface and DevSound
Root Cause of the problem: New feature.
Files Added:
datatype/mp4/audio/renderer/ac3decinfo.cpp
datatype/mp4/audio/renderer/ac3decinfo.h
datatype/mp4/audio/renderer/eac3decinfo.cpp
datatype/mp4/audio/renderer/eac3decinfo.h
Files Modified:
/build/umakepf/helix_client_s60_52_common.pfi
/clientapps/symbianMmf/hxmmffourccmap.cpp
/clientapps/symbianMmf/hxmmfmimetypes.h
/datatype/avi/fileformat/avistrm.cpp
/datatype/mdf/audio/dsp/mdfauddecoder.cpp
/datatype/mdf/audio/dsp/mdfaudfmt.cpp
/datatype/mdf/audio/dsp/mdfaudfmt.h
/datatype/mdf/audio/dsp/mdfdevconfig.cpp
/datatype/mdf/audio/dsp/mdfdevconfig.h
/datatype/mdf/audio/dsp/mdfdevsound.cpp
/datatype/mkv/fileformat/mkv_file_format.cpp
/datatype/mp4/audio/renderer/mdfhwdecinfo.cpp
/datatype/mp4/audio/renderer/mdfhwdecinfo.h
/datatype/mp4/audio/renderer/mp4adec.cpp
/datatype/mp4/audio/renderer/mp4audio.cpp
/datatype/mp4/audio/renderer/libumakefil
/datatype/mp4/payload/pub/mp4apyld.h
/datatype/mp4/payload/mp4apyld.cpp
Image Size and Heap Use impact:
minor
Module Release testing (STIF) : Passed local test cases.
Test case(s) Added : No.
Memory leak check performed : Yes. No new leaks introduced
Platforms and Profiles Build Verified: helix-client-s60-52-mmf-mdf-dsp
Platforms and Profiles Functionality verified: armv5
Branch: Brizo_420
-----------------------------------------------------------------------------------------------------------------------------
"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."
Modified by: Gang.Jia@nokia.com
Reviewed by:
Date: 11/18/2009
Project: SymbianMmf_wm
ErrorId: GJIA-7XEUBR
Synopsis: CR GJIA-7XEUBR When play Dolby Digital 5.1 or 7.1 channels, \
CMMFDevSound::SetConfigL leaves with KErrArgument.
The SetConfigL only takes channel numbers as EMono and EStereo. Helix should not set \
channel numbers to larger than 2 on this interface. For the multi-channel Dolby \
Digital contents the channel number info can be retrieved by DD+ decoder from each \
audio frame.
Root Cause of the problem: Implementation.
Files Added:
none
Files Modified:
/datatype/mdf/audio/dsp/mdfaudfmt.cpp
Image Size and Heap Use impact:
minor
Module Release testing (STIF) : Passed local test cases.
Test case(s) Added : No.
Memory leak check performed : Yes. No new leaks introduced
Platforms and Profiles Build Verified: helix-client-s60-52-mmf-mdf-dsp
Platforms and Profiles Functionality verified: armv5
Branch: 420Brizo
-----------------------------------------------------------------------------------------------------------------------------
"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."
Modified by: Gang.Jia@nokia.com
Reviewed by:
Date: 12/14/2009
Project: SymbianMmf_wm
ErrorId: ELDG-7YQTQQ
Synopsis: CR ELDG-7YQTQQ Dolby Digital AC3 Helix can not play MKV with multiple \
frames per block.
In MKV file format one audio block may contain multiple Dolby Digital audio frames. \
This will cause the audio buffer payload size larger than the audio device buffer \
size. Helix drops these frames in frame mode. The fix is to add DD frame parsing at \
HXMDFAudioFormat to get each DD audio frame to send to the MDF audio device.
Root Cause of the problem: Implementation.
Files Added:
none
Files Modified:
/datatype/mdf/audio/dsp/mdfaudfmt.cpp
/datatype/mdf/audio/dsp/mdfaudfmt.h
Image Size and Heap Use impact:
minor
Module Release testing (STIF) : Passed local test cases.
Test case(s) Added : No.
Memory leak check performed : Yes. No new leaks introduced
Platforms and Profiles Build Verified: helix-client-s60-52-mmf-mdf-dsp
Platforms and Profiles Functionality verified: armv5
Branch: 420Brizo
-----------------------------------------------------------------------------------------------------------------------------
Modified by: ext-amit.shivnani@nokia.com
Reviewed by:
Date: 22-June-2009
Project: Helix
Error ID: EASI-7T9T8F
Synopsis: Helix Thumbnail Engine does not return correct error code to VTNE \
clients In cases like low memory conditions , the Helix Thumbnail Engine does not \
foward the correct error code coming from lower layers (MDF,decoder) to VTNE clients \
. This prevents the clients from acting appropriately according to the error code .
Soilution : Helix Thumbnail utility is to sent the correct error code to the VTNE \
server when it leaves due to error .
Files Modified:
datatype/tools/metadataeng/utility/platform/symbian/hxtnutil_impl.cpp
New files added:
None.
Image Size and Heap Use impact: no major impact
Module Release testing (STIF) : NA
Test case(s) Added : No
Index: hxtnutil_impl.cpp
===================================================================
RCS file: /cvsroot/datatype/tools/metadataeng/utility/platform/symbian/hxtnutil_impl.cpp,v
retrieving revision 1.1
retrieving revision 1.1.22.1
diff -u -d -r1.1 -r1.1.22.1
--- hxtnutil_impl.cpp 24 Jan 2008 17:10:32 -0000 1.1
+++ hxtnutil_impl.cpp 23 Dec 2009 22:55:31 -0000 1.1.22.1
@@ -51,7 +51,7 @@
#include <E32Base.h>
#include <e32std.h>
#include <flogger.h>
-
+#include <mmf/common/MmfErrors.h>
#include "hxmediasource.h"
#include "hxmetadatakeys.h"
#include "hxtnutil_impl.h"
@@ -90,6 +90,11 @@
}
#endif
+struct HXSymbianStatus
+{
+ HX_RESULT m_HelixStatus;
+ TInt m_SymbianStatus;
+};
@@ -158,15 +163,49 @@
FLOG(_L("CHXThumbnailUtilityImpl::OpenFileL By RFile OpenSource=%d\n"), hxr);
- // XXX Global mapping of Helix to Symbian error codes is needed
if (hxr != HXR_OK)
{
m_bCloseNeeded = EFalse;
- User::Leave(KErrNotSupported);
+ TInt err = MapToSymbianError(hxr);
+ FLOG(_L(" SYMBIAN ERROR VALUE IS %d"),err);
+ User::Leave(err);
}
FLOG(_L("CHXThumbnailUtilityImpl::OpenFileL Done\n"));
}
+static const HXSymbianStatus ErrStatusMap[] =
+{
+ { HXR_OK, KErrNone },
+ { HXR_FAIL, KErrGeneral },
+ { HXR_OUTOFMEMORY, KErrNoMemory },
+ { HXR_UNSUPPORTED_VIDEO, KErrNotSupported },
+ { HXR_NO_FILESYSTEM, KErrNotSupported },
+ { HXR_NOT_SUPPORTED, KErrNotSupported },
+ { HXR_READ_ERROR, KErrCorrupt },
+ { HXR_NOT_AUTHORIZED, KErrPermissionDenied },
+ { HXR_DEVVIDEO_FATAL_ERROR, KErrMMVideoDevice },
+ { HXR_BAD_FORMAT, KErrNotSupported },
+ { HXR_BAD_SERVER, KErrCouldNotConnect }
+
+};
+
+static const int NumErrStatus = sizeof(ErrStatusMap)/sizeof(HXSymbianStatus);
+TInt CHXThumbnailUtilityImpl::MapToSymbianError( HX_RESULT status)
+{
+
+ TInt symbianError = KErrNotSupported;
+ TBool found = false;
+
+ for (int i=0; !found && i < NumErrStatus; i++)
+ {
+ if ( ErrStatusMap[i].m_HelixStatus == status )
+ {
+ found = true;
+ symbianError = ErrStatusMap[i].m_SymbianStatus;
+ }
+ }
+ return symbianError;
+}
/*
loads the engine dll and creates the engine object by
calling the entry point from the dll.
_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic