[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-datatype-cvs
Subject: [Datatype-cvs] wm/fileformat asf_stream_hdr_utils.cpp, 1.2.2.1.2.1,
From: jzamora () helixcommunity ! org
Date: 2009-08-31 13:35:32
Message-ID: 200908311444.n7VEiqXL006437 () mailer ! progressive-comp ! com
[Download RAW message or body]
Update of /cvsroot/datatype/wm/fileformat
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv1344
Modified Files:
Tag: hxclient_2_1_0_cayennes
asf_stream_hdr_utils.cpp
Log Message:
"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."
Modified by: ext-jose-antonio.2.zamora@nokia.com
Reviewed by:
TSW Id: AJUA-7ULC2K
Date: 28/08/2009
Project: SymbianMmf_wm
Synopsis: SPPR_PERF AppArcServer crashes when there is corrupted wma file in \
filemanager view.
Overview:
In HXASFSetMetadataObjectProperty() method, helix gets and sets the values of \
DRCPeakReference, DRCAverageReference, DRCPeakTarget and DRCAverageTarget attributes, \
but some of the values from these attributes are empty, so when helix tries to read \
the data from a null pointer it crashes.
Fix:
added a null pointer check which prevents the crash in \
HXASFSetMetadataObjectProperty() method.
Files modified & changes:
\datatype\wm\fileformat\asf_stream_hdr_utils.cpp
Image Size and Heap Use impact: None
Module Release testing (STIF, Audio) : Passed
Test case(s) Added : No
Memory leak check performed : Passed, No leaks found
Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-arm
helix-client-s60-32-mmf-mdf-arm
Platforms and Profiles Functionality verified: armv5
Branch: 223Cays, 221Cays, 210Cays, HEAD
Index: asf_stream_hdr_utils.cpp
===================================================================
RCS file: /cvsroot/datatype/wm/fileformat/asf_stream_hdr_utils.cpp,v
retrieving revision 1.2.2.1.2.1
retrieving revision 1.2.2.1.2.2
diff -u -d -r1.2.2.1.2.1 -r1.2.2.1.2.2
--- asf_stream_hdr_utils.cpp 7 Aug 2007 21:40:29 -0000 1.2.2.1.2.1
+++ asf_stream_hdr_utils.cpp 31 Aug 2009 13:35:30 -0000 1.2.2.1.2.2
@@ -120,7 +120,8 @@
{
if (pObj->m_pDescriptionRecord[i].m_pszName &&
!strcmp(pszWMPropName, pObj->m_pDescriptionRecord[i].m_pszName) &&
- pObj->m_pDescriptionRecord[i].m_usStreamNumber == usWMStreamNum)
+ pObj->m_pDescriptionRecord[i].m_usStreamNumber == usWMStreamNum &&
+ pObj->m_pDescriptionRecord[i].m_pData)
{
switch (pObj->m_pDescriptionRecord[i].m_usDataType)
{
_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic