[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs] mdf/audio/dsp mdfauddecoder.cpp,1.5,1.6
From:       rkondru () helixcommunity ! org
Date:       2009-06-22 19:46:21
Message-ID: 200906222052.n5MKqDfL001755 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/datatype/mdf/audio/dsp
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv3343

Modified Files:
	mdfauddecoder.cpp 
Log Message:
"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."

Modified by: ext-ramesh.kondru@nokia.com

Reviewed by: Liu Junhong,Dhamija Anuj

Date: 06/16/2009

Project: SymbianMmf_wm
 
ErrorId: N/A 

Synopsis: WMV / WMA - Helix pops up "cannont be played" 

Overview: 
	 The reason for this is that we moved to updated WMA porting kit from Microsoft \
which supports WMA 10 (and also includes the same support that our WMA9 decoder has). \
Therefore for WMA 2-9 we now have two decoders which should be able to play this \
content. So by default, we take the newer WMA 10 decoder to play this content.

	  But in audioconfig.cpp for Symbian we still do comparision with \
"WMDECODER_CODEC_NAME_WMA9" and return's since it does not match with mimetype of \
wma10. Reason when the mime type is read we set fourcc value to \
"WMDECODER_CODEC_NAME_WMA10" in  CWMAudioDecoder::GetCodecInfo. But comparision is \
always done with "WMDECODER_CODEC_NAME_WMA9" which is why it fails.

	  So we need to move to the new "WMDECODER_CODEC_NAME_WMA10" since by default \
wma9/wma10 is supported with new porting kit.

Files modified: /cvsroot/datatype/mdf/audio/arm/wma/platform/symbian/wmaaudioconfigs.cpp
  /cvsroot/datatype/mdf/audio/dsp/mdfauddecoder.cpp

Files added: None

Image Size and Heap Use impact: None.

Module Release testing (STIF) : Yes 

Test case(s) Added  : No
  
Memory leak check performed : Yes. No new memory leaks introduced.
  
Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-arm-dsp

Platforms and Profiles Functionality verified: armv5, winscw 
  
Branch: HEAD

Index: mdfauddecoder.cpp
===================================================================
RCS file: /cvsroot/datatype/mdf/audio/dsp/mdfauddecoder.cpp,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -d -r1.5 -r1.6
--- mdfauddecoder.cpp	31 Mar 2009 19:32:45 -0000	1.5
+++ mdfauddecoder.cpp	22 Jun 2009 19:46:19 -0000	1.6
@@ -461,7 +461,7 @@
         m_pAudioFormat = new HXMDFAudioAac();
     }
     else 
-    if(strcmp("WMA9", fourCC) == 0)
+    if((strcmp("WMA9", fourCC) == 0) || (strcmp("wmaA", fourCC) == 0))
     {
         HXLOGL2(HXLOG_MDFA, "mdfdec:createFmt .. wma:%s", fourCC);
         m_pAudioFormat = new HXMDFAudioWMA(m_pContext);


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs


[prev in list] [next in list] [prev in thread] [next in thread]