[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs]
From:       sgrosdes () helixcommunity ! org
Date:       2009-01-30 17:13:15
Message-ID: 200901301716.n0UHGDdE014164 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/datatype/mdf/video/format/h263
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv9145/video/format/h263

Modified Files:
	mdfh263payloadformat.cpp 
Log Message:
>    "Nokia submits this code under the terms of a commercial contribution agreement with RealNetworks,
>and I am authorized to contribute this code under said agreement."
>
>Modified by: EXT-Sebastien.Gros2@nokia.com
>Reviewed by:
>Date: Janurary 29 -2009
>
>
>
>ErrorId: N/A
>
>Description:
>
>Products builds don't stand the change made for error LTUA-7MFQRW. Clips are played only partially on
>the phones having the changes.
>
>
>
>
>
>Solution:
>
>Remove the profile information in the relevant derived classes for H264, H263 and MP4:
>
>m_pPictureHeader.iProfile =m_lProfile;
>
>
>
>
>
>In mdfh263payloadformat.h
>
>
>
>     virtual void    SetVideoDataUnit();
>- virtual HXBOOL  FormPictureHeader( TVideoPictureHeader& pPictureHeader );
>     HX_RESULT       GetFMTParams( IHXValues*& pFMTParams );
>
>
>
>In mdfh263payloadformat.cpp
>
>
>
>     MDFVIDEOLOG_LEAVEFN( "SetVideoDataUnit" );
> }
>
>-HXBOOL CH263PayloadFormatPluginDevice::FormPictureHeader( TVideoPictureHeader& pPictureHeader )
>-{
>-    MDFVIDEOLOG_ENTERFN( "FormPictureHeader" );
>-
>-    HXBOOL retVal = TRUE;
>-
>-    //fill iSizeInMemory and iDisplayedRect fields of pPictureHeader
>-    //must be placed here since width and height are found in
>-    //the derived class, ignore the return status
>-    CPayloadFormatPluginDevice::FormPictureHeader( pPictureHeader );
>-
>- //getting the profile level
>- pPictureHeader.iProfile = m_lProfile;
>-
>-    MDFVIDEOLOG_RETURNFN( "FormPictureHeader", retVal );
>-    return retVal;
>-}
>-
> HX_RESULT CH263PayloadFormatPluginDevice::GetFMTParams( IHXValues*& pFMTParams )
> {
>     MDFVIDEOLOG_ENTERFN( "GetFMTParams" );
>
>In mdfh264payloadformat.cpp
>
>     //the derived class, ignore the return status
>     CPayloadFormatPluginDevice::FormPictureHeader( pPictureHeader );
>-
>- //getting the profile level
>- pPictureHeader.iProfile = m_lProfile;
>
>     MDFVIDEOLOG_RETURNFN( "FormPictureHeader", retVal );
>
>in mdfmp4payloadformat.cpp
>
>     //the derived class, ignore the return status
>     CPayloadFormatPluginDevice::FormPictureHeader( pPictureHeader );
>-
>- //getting the profile level
>- pPictureHeader.iProfile = m_lProfile;
>
>     MDFVIDEOLOG_RETURNFN( "FormPictureHeader", retVal );
>
>Files Modified:
>datatype\mdf\video\format\h263\pub\mdfh263payloadformat.h
>datatype\mdf\video\format\h263\mdfh263payloadformat.cpp
>datatype\mdf\video\format\h264\mdfh264payloadformat.cpp
>datatype\mdf\video\format\mp4\mdfmp4payloadformat.cpp
>
>New files added: NONE
>
>
>
>Image Size and Heap Use impact: no major impact
>
>
>
>Module Release testing (STIF) : Passed
>
>Memory Leaks testing: Passed
>
>Test case(s) Added : No.
>
>
>Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-arm
>Platforms and Profiles Functionality verified: armv5
>
>Branch: 210 Cayennes, HEAD


Index: mdfh263payloadformat.cpp
===================================================================
RCS file: /cvsroot/datatype/mdf/video/format/h263/mdfh263payloadformat.cpp,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -d -r1.13 -r1.14
--- mdfh263payloadformat.cpp	21 Jan 2009 18:06:56 -0000	1.13
+++ mdfh263payloadformat.cpp	30 Jan 2009 17:13:13 -0000	1.14
@@ -342,23 +342,6 @@
     MDFVIDEOLOG_LEAVEFN( "SetVideoDataUnit" );
 }
 
-HXBOOL CH263PayloadFormatPluginDevice::FormPictureHeader( TVideoPictureHeader& pPictureHeader )
-{
-    MDFVIDEOLOG_ENTERFN( "FormPictureHeader" );
-
-    HXBOOL retVal = TRUE; //set to true for consistancy
-
-    //fill iSizeInMemory and iDisplayedRect fields of pPictureHeader
-    //must be placed here since width and height are found in 
-    //the derived class, ignore the return status
-    CPayloadFormatPluginDevice::FormPictureHeader( pPictureHeader );
-	
-	//getting the profile level
-	pPictureHeader.iProfile = m_lProfile;
-
-    MDFVIDEOLOG_RETURNFN( "FormPictureHeader", retVal );
-    return retVal;
-}
 
 HX_RESULT CH263PayloadFormatPluginDevice::GetFMTParams( IHXValues*& pFMTParams )
 {


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs
[prev in list] [next in list] [prev in thread] [next in thread]