[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs] mp4/common avcconfig.cpp,1.5,1.6
From:       jrathore () helixcommunity ! org
Date:       2008-12-22 22:51:40
Message-ID: 200812222253.mBMMrOoc024600 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/datatype/mp4/common
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv2221

Modified Files:
	avcconfig.cpp 
Log Message:
Modified by: jrathore@real.com

Date: 12/22/08

Project: Helix DNA Client

 

Synopsis: Fix an infinite loop bug in avcconfig.cpp on HEAD

 

Overview: This change prevents an infinite loop in AVCConfigurationBox::Unpack() \
function in avcconfig.cpp on HEAD. 

 

Files Added: None

 

Files Modified:

avcconfig.cpp (/datatype/mp4/common/avcconfig.cpp)

 

Image Size and Heap Use impact (Client -Only): None

 

Platforms and Profiles Affected:

Platform: win32-i386-vc7

Profile: helix-client-all-defines

 

Platforms and Profiles Build and Functionality Verified:

Platform: win32-i386-vc7

Profile: helix-client-all-defines

target(s): splay

 

Branch: HEAD

 

Copyright assignment: I am a RealNetworks employee.

 

Files Attached: avcconfig.diff

 

-Jyotsana

-


Index: avcconfig.cpp
===================================================================
RCS file: /cvsroot/datatype/mp4/common/avcconfig.cpp,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -d -r1.5 -r1.6
--- avcconfig.cpp	8 Aug 2008 21:21:39 -0000	1.5
+++ avcconfig.cpp	22 Dec 2008 22:51:36 -0000	1.6
@@ -129,6 +129,10 @@
     	    pData += 8;
     	    ulSize -= 8;
     	} else {
+            if (m_ulSize == 0)
+            {
+                break;
+            }
     	    pData += m_ulSize;
     	    ulSize -= m_ulSize;
     	}


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs


[prev in list] [next in list] [prev in thread] [next in thread]