[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs] mdf/video/renderer/mdfdevice/server
From:       gashish () helixcommunity ! org
Date:       2008-10-28 15:22:26
Message-ID: 200810281529.m9SFTJa8026075 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/datatype/mdf/video/renderer/mdfdevice/server
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv9414/mdfdevice/server

Modified Files:
	CMDFDevVideoServerSession.cpp 
Log Message:
Setting up property watch causing crash for thumbnail

Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."

Modified by:  ashish.as.gupta@nokia.com

Reviewed by: ehyce@real.com

Date: 27-Oct-2008

Project: symbianMmf_rel

TSW-Id: DALM-7KTQVZ

Synopsis: 

1. MDF video adapter is creating the prop watch without checking whether property \
exist or not. In case of thumbnail engine, this results in the crash due to absence \
of the property. This is fixed by ensuring that prop watch will be created only if \
the property exists.

2. A check is also introduced so that PostProcessor custom interfaces are requested \
only when the post-processor is enabled.

Files Modified:

datatype/mdf/video/renderer/mdfvideoadapter.cpp
datatype/mdf/video/renderer/mdfdevice/server/CMDFDevVideoServerSession.cpp

Image Size and Heap Use impact: none

Module Release testing (STIF): Yes.

Test case(s) Added: none

Memory leak check performed: Yes, no new leaks introduced.

Platforms and Profiles Build Verified: 
    armv5 / helix-client-s60-50-mmf-mdf-dsp
    winscw / helix-client-s60-50-mmf-mdf-dsp

Platforms and Profiles Functionality verified: 
    armv5 / helix-client-s60-50-mmf-mdf-dsp
    winscw / helix-client-s60-50-mmf-mdf-dsp

Branch: 
    HEAD, hxclient_2_1_0_cayennes



Index: CMDFDevVideoServerSession.cpp
===================================================================
RCS file: /cvsroot/datatype/mdf/video/renderer/mdfdevice/server/CMDFDevVideoServerSession.cpp,v
 retrieving revision 1.8
retrieving revision 1.9
diff -u -d -r1.8 -r1.9
--- CMDFDevVideoServerSession.cpp	20 Oct 2008 17:01:23 -0000	1.8
+++ CMDFDevVideoServerSession.cpp	28 Oct 2008 15:22:23 -0000	1.9
@@ -739,31 +739,38 @@
         // Error not fatal
     }
 #endif
-    
-#if defined(HELIX_FEATURE_S60_TRICKPLAY)
-     m_pTriclPlayControl =
-		 (MMmfVideoPlayRateControl *) m_pDevVideoPlay->CustomInterface( \
m_PostProcessorHwDeviceId, KUidMmfVideoPlayRateControl );  
-	 if( m_pTriclPlayControl )
-	 {
-		 m_pTriclPlayControl->MmvprcSetObserver( *this );
-	 }
+#if defined(HELIX_FEATURE_S60_TRICKPLAY)
+    if (!pInitParams->m_bDisablePostProcessor)
+    {
+        m_pTriclPlayControl =
+        (MMmfVideoPlayRateControl *) m_pDevVideoPlay->CustomInterface( \
m_PostProcessorHwDeviceId, KUidMmfVideoPlayRateControl ); +        
+        if( m_pTriclPlayControl )
+        {
+         m_pTriclPlayControl->MmvprcSetObserver( *this );
+        }
+	}
 #endif  //HELIX_FEATURE_S60_TRICKPLAY
 
 #if defined HELIX_FEATURE_S60_VIDEO_CUSTOM_INTERFACE
-    MMmfVideoPropertiesNotifier* pVideoPropertiesNotifier = 
-    															(MMmfVideoPropertiesNotifier *) \
m_pDevVideoPlay->CustomInterface(m_PostProcessorHwDeviceId,KUidMmfVideoPropertiesManagement);
                
-    if(pVideoPropertiesNotifier)
+    if (!pInitParams->m_bDisablePostProcessor)
     {
-        pVideoPropertiesNotifier->MmvpnSetObserver((MMmfVideoPropertiesObserver*)this);
                
-    }
+        MMmfVideoPropertiesNotifier* pVideoPropertiesNotifier = 
+    		(MMmfVideoPropertiesNotifier *) m_pDevVideoPlay->CustomInterface(
+    		            m_PostProcessorHwDeviceId,KUidMmfVideoPropertiesManagement);
+        if(pVideoPropertiesNotifier)
+        {
+            pVideoPropertiesNotifier->MmvpnSetObserver((MMmfVideoPropertiesObserver*)this);
 +        }
 		else
 		{
 			  SERVER_LOG( (_L("CMDFDevVideoServerSession[%x]::CreateDevVideoL \
PMMmfVideoPropertiesNotifier not avilable"), this));   }    			
-    
+    }
 #endif
     User::LeaveIfError(lRetval);
+    
 }
 
 //


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs


[prev in list] [next in list] [prev in thread] [next in thread]