[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs] mdf/video/renderer mdfvideoadapter.cpp, 1.3.2.69,
From:       jwei () helixcommunity ! org
Date:       2007-10-29 15:23:23
Message-ID: 200710291523.l9TFNv5P015666 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/datatype/mdf/video/renderer
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv23880

Modified Files:
      Tag: hxclient_2_1_0_cayennes
	mdfvideoadapter.cpp 
Log Message:

Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."

Modified by:  john.wei@nokia.com

Reviewed by:

Date: 16-Oct-2007

Project: SymbianMmf_Rel

TSW: EAKA-778LLD

Synopsis: Removing SetBufferOptionsL() call to DevVideo

This CR proposes to remove "SetBufferOptionsL( CMMFDevVideoPlay::TBufferOptions )" \
call to DevVideo by mdfrenderer in mdfvideoadapter.cpp. \
TBufferOptions.iMaxInputBufferSize depends on profile and level of video clip, which \
renderer could not get accurate or reliable value. Decoder, by parsing head stream, \
could obtain the accurate value. TBufferOptions.iMinNumInputBuffers is also decoder's \
responsibility. Furthermore, renderer is not required to make SetBufferOptionsL() \
based on DevVideo implementation guideline.

Files Modified:

/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp

Index: mdfvideoadapter.cpp
===================================================================
RCS file: /cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
retrieving revision 1.3.2.69
diff -u -w -b -r1.3.2.69 mdfvideoadapter.cpp
--- mdfvideoadapter.cpp	27 Sep 2007 20:48:03 -0000	1.3.2.69
+++ mdfvideoadapter.cpp	17 Oct 2007 18:42:05 -0000
@@ -576,12 +576,14 @@
         m_pDevVideoPlay->SynchronizeDecoding( bSynDec );
         MDFVIDEOLOG_WRITE_FORMAT2( "    SynchronizeDecoding() is set to %d", bSynDec \
);  
-        CMMFDevVideoPlay::TBufferOptions bufferOptions;
-        bufferOptions.iMaxInputBufferSize = (352*288);
-        bufferOptions.iMinNumInputBuffers = 2;
+        //m_pDevVideoPlay->SetBufferOptionsL( CMMFDevVideoPlay::TBufferOptions ) is \
not called +        //since TBufferOptions.iMaxInputBufferSize depends on profile and \
level of video +        //clip, which renderer could not get accurate or reliable \
value. Decoder, by parsing +        //head stream, could obtain the accurate value. \
TBufferOptions.iMinNumInputBuffers is +        //also decoder's responsibility.
+        //Furthermore, renderer is not required to make SetBufferOptionsL() based on \
DevVideo +        //implementation guideline.
 
-        m_pDevVideoPlay->SetBufferOptionsL( bufferOptions );
-        MDFVIDEOLOG_INOUTFN( "SetBufferOptionsL() does not leave" );
 
         m_pDevVideoPlay->SetPostProcessTypesL( m_PostProcessorHwDeviceId,
                             EPpInputCrop | EPpOutputCrop | EPpScale | EPpRotate | \
EPpYuvToRgb); ====================================================== Image Size and \
Heap Use impact: minor

Module Release testing (STIF) :  N/A

Test case(s) Added  :  no

Memory leak check performed : Yes.  No new leaks introduced.  

Platforms and Profiles Build Verified: helix-client-s60-32-mmf-mdf-arm

Platforms and Profiles Functionality verified: armv5, winscw 

Branch: Head & 210CayS

Index: mdfvideoadapter.cpp
===================================================================
RCS file: /cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
retrieving revision 1.3.2.69
retrieving revision 1.3.2.70
diff -u -d -r1.3.2.69 -r1.3.2.70
--- mdfvideoadapter.cpp	27 Sep 2007 20:48:03 -0000	1.3.2.69
+++ mdfvideoadapter.cpp	29 Oct 2007 15:23:20 -0000	1.3.2.70
@@ -576,12 +576,14 @@
         m_pDevVideoPlay->SynchronizeDecoding( bSynDec );
         MDFVIDEOLOG_WRITE_FORMAT2( "    SynchronizeDecoding() is set to %d", bSynDec \
);  
-        CMMFDevVideoPlay::TBufferOptions bufferOptions;
-        bufferOptions.iMaxInputBufferSize = (352*288);
-        bufferOptions.iMinNumInputBuffers = 2;
+        //m_pDevVideoPlay->SetBufferOptionsL( CMMFDevVideoPlay::TBufferOptions ) is \
not called +        //since TBufferOptions.iMaxInputBufferSize depends on profile and \
level of video +        //clip, which renderer could not get accurate or reliable \
value. Decoder, by parsing +        //head stream, could obtain the accurate value. \
TBufferOptions.iMinNumInputBuffers is +        //also decoder's responsibility.
+        //Furthermore, renderer is not required to make SetBufferOptionsL() based on \
DevVideo +        //implementation guideline.
 
-        m_pDevVideoPlay->SetBufferOptionsL( bufferOptions );
-        MDFVIDEOLOG_INOUTFN( "SetBufferOptionsL() does not leave" );
 
         m_pDevVideoPlay->SetPostProcessTypesL( m_PostProcessorHwDeviceId,
                             EPpInputCrop | EPpOutputCrop | EPpScale | EPpRotate | \
EPpYuvToRgb);


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs


[prev in list] [next in list] [prev in thread] [next in thread]