[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs] mdf/video/format/wmv mdfwmvpayloadformat.cpp, 1.4,
From:       jwei () helixcommunity ! org
Date:       2007-06-28 21:55:41
Message-ID: 200706282156.l5SLu5kQ012436 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/datatype/mdf/video/format/wmv
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv23960/video/format/wmv

Modified Files:
	mdfwmvpayloadformat.cpp 
Log Message:

Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."

Modified by:  john.wei@nokia.com

Reviewed by:

Date: 18-June-2007

Project: SymbianMmf_Rel

TSW: TBD

Synopsis: MDF Video Renderer - fix decoder and postprocessor mismatch

In the file \datatype\mdf\video\format\common\mdfpayloadformat.cpp,

Before 4/7/07, following method was declared as 

==================================================
XBOOL CMdfPluginManager::IsDecoderSupportMimeTypeL( const CVideoDecoderInfo* \
pDecoderInfo, const TDesC8& aMimeType, const CCompressedVideoFormat*& \
pCCompressedVideoFormat ) const ==================================================


After 4/7/07, it is modified as following to accommodate WM:

==================================================
HXBOOL CMdfPluginManager::IsDecoderSupportMimeTypeL( const CVideoDecoderInfo* \
pDecoderInfo, const CPayloadFormatInfo* aPayloadInfo , const CCompressedVideoFormat*& \
pCCompressedVideoFormat ) const ==================================================

This method is used in the way as follows:

==================================================

for( TInt m = 0; m < payloadformatCount; m++ ) 

{ 

if( payloadformatinfo->SupportMimeType( aMimeType ) ) 

{

for( TInt j = 0; j < decoderCount; j++ ) 

{

if( IsDecoderSupportMimeTypeL( decoderInfo, *convertedMimeType, format ) ) //before \
4/7/07 

if( IsDecoderSupportMimeTypeL( decoderInfo, payloadformatinfo, format ) )  //after \
4/7/07 

{ 

==================================================

IsDecoderSupportMimeTypeL() is meant to check if decoder supports a particular \
mimetype. However modified version is made to check if decoder and payloadformat have \
common mimetype, instead of this particular mimetype. This causes decoders could be \
paired wrongly with postprocessors, which resulting in video not played at all for \
affected mimetypes.

This CR proposes to fix the bug stated above.

Files Modified:

/cvsroot/datatype/mdf/video/format/common/mdfpayloadformat.cpp
/cvsroot/datatype/mdf/video/format/common/pub/mdfpayloadformat.h
/cvsroot/datatype/mdf/video/format/h263/mdfh263payloadformat.cpp
/cvsroot/datatype/mdf/video/format/h264/mdfh264payloadformat.cpp
/cvsroot/datatype/mdf/video/format/mp4/mdfmp4payloadformat.cpp
/cvsroot/datatype/mdf/video/format/rm/mdfrvxpayloadformat.cpp
/cvsroot/datatype/mdf/video/format/wmv/mdfwmvpayloadformat.cpp
/cvsroot/datatype/mdf/video/renderer/mdfpluginmanager.cpp
/cvsroot/datatype/mdf/video/renderer/pub/mdfpluginmanager.h
/cvsroot/datatype/mdf/video/renderer/mdfpluginarchive.cpp
/cvsroot/datatype/mdf/video/renderer/pub/mdfpluginpackage.h
/cvsroot/datatype/mdf/video/renderer/mdfpluginpackage.cpp
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp

======================================================
Image Size and Heap Use impact: minor

Module Release testing (STIF) :  Passed

Test case(s) Added  :  None

Memory leak check performed : Yes.  No new leaks introduced.  

Platforms and Profiles Build Verified: helix-client-s60-32-mmf-mdf-arm

Platforms and Profiles Functionality verified: armv5, winscw 

Branch: Head & 210CayS


Index: mdfwmvpayloadformat.cpp
===================================================================
RCS file: /cvsroot/datatype/mdf/video/format/wmv/mdfwmvpayloadformat.cpp,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -d -r1.4 -r1.5
--- mdfwmvpayloadformat.cpp	30 May 2007 15:47:25 -0000	1.4
+++ mdfwmvpayloadformat.cpp	28 Jun 2007 21:55:39 -0000	1.5
@@ -377,20 +377,14 @@
     _LIT8( KVideoMimeTypeRNWMV, "video/x-hx-wmv" );
     _LIT8( KVideoMimeTypeVC1, "video/vc1" );
     _LIT8( KVideoMimeTypeWMV, "video/x-ms-wmv" );
-
-    _LIT8( KVideoMimeTypeKeywordWMV, "wmv" );
     _LIT8( KVideoMimeTypeKeywordVC1, "vc1" );
 
 
     aPayloadFormatInfo.Reset();
 
-    aPayloadFormatInfo.AppendMimeType( KVideoMimeTypeRNWMV );
-    aPayloadFormatInfo.AppendMimeType( KVideoMimeTypeWMV );
-    aPayloadFormatInfo.AppendMimeType( KVideoMimeTypeVC1 );
-
-    aPayloadFormatInfo.AppendMimeTypeKeyword( KVideoMimeTypeKeywordWMV );
-    aPayloadFormatInfo.AppendMimeTypeKeyword( KVideoMimeTypeKeywordVC1 );
-
+    aPayloadFormatInfo.AppendMimeType( KVideoMimeTypeRNWMV, KVideoMimeTypeKeywordVC1 \
); +    aPayloadFormatInfo.AppendMimeType( KVideoMimeTypeWMV, \
KVideoMimeTypeKeywordVC1 ); +    aPayloadFormatInfo.AppendMimeType( \
KVideoMimeTypeVC1, KVideoMimeTypeKeywordVC1 );  
     aPayloadFormatInfo.SetPayloadFormatId( KUidWMVPayloadFormatPluginDevice );
 


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs


[prev in list] [next in list] [prev in thread] [next in thread]