[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs] mdf/video/renderer mdfvideoadapter.cpp, 1.3.2.61,
From:       suramakr () helixcommunity ! org
Date:       2007-04-30 18:23:25
Message-ID: 200704301824.l3UIO64r031274 () dommarcmx ! xen ! 10east ! com
[Download RAW message or body]

Update of /cvsroot/datatype/mdf/video/renderer
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv561

Modified Files:
      Tag: hxclient_2_1_0_cayennes
	mdfvideoadapter.cpp 
Log Message:
"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."  
Modified by:  sunitha.ramakrishna@nokia.com
 
Reviewed by: 
 
Date: 4/23/2007
 
Project: SymbianMmf
 
ErrorId:  SRAA-72JNAF
 
Synopsis: Playing video in full screen on DSP platforms would result in the video \
being scaled but not rotated. This problem arises because DevVideo Initialize can be \
synchronous or asynchronous. In the asynchronous case the FrameRect and the Rotation \
would be sent to DevVideo as InitComplete callback would not have been received prior \
to the core sending these values.

The problem can be resolved by setting the FrameRect and Rotation inside of \
SetupWindow. FrameRect requires a validity check, since we cannot assume that the \
FrameRect has been set. The mdfadapter can take care of an undefined Frame Rect.

Rotation does not require this check since the default value for rotation in the \
global parameter is 0, which has no effect. 

The CR has been tested on both DSP and ARM platforms
 

    
Root Cause of the problem: Implementation 
 

Files Modified:
datatype/mdf/video/renderer/mdfvideoadapter.cpp
common/system/platform/symbian/symbianglobalvideoparameters.cpp
common/system/platform/pub/symbian/symbianglobalvideoparameters.h

Files Added: 
 
 
Image Size and Heap Use impact: None

Module Release testing (STIF) : Yes 

Test case(s) Added  :  N/A 
  
Memory leak check performed : Yes, no new leaks have been introduced
  
Platforms and Profiles Build Verified: helix-client-s60-32-mmf-mdf-arm
                                       helix-client-s60-32-mmf-mdf-dsp

Platforms and Profiles Functionality verified: armv5, winscw 
  
Branch: Head & 210CayS

Index: mdfvideoadapter.cpp
===================================================================
RCS file: /cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
retrieving revision 1.3.2.61
retrieving revision 1.3.2.62
diff -u -d -r1.3.2.61 -r1.3.2.62
--- mdfvideoadapter.cpp	27 Apr 2007 15:37:26 -0000	1.3.2.61
+++ mdfvideoadapter.cpp	30 Apr 2007 18:23:21 -0000	1.3.2.62
@@ -1194,7 +1194,19 @@
         SetWindowParameters(winRect, clipRect);
 
         (SymbianGlobalVideoParameters::Instance())->GetDisplayRegion((HXxRegion)&m_ClipRegion);
                
-
+        
+        if ((SymbianGlobalVideoParameters::Instance())->IsFrameRectValid() == TRUE)
+        {
+         HXxRect frameRect;
+         (SymbianGlobalVideoParameters::Instance())->GetFrameRect(frameRect);
+         SetFrameRect(frameRect);
+        }
+        
+        UINT32  rotationValue;
+        (SymbianGlobalVideoParameters::Instance())->GetRotationValue(rotationValue);
+        SetRotation(rotationValue);
+       
+         
         TInt count = m_ClipRegion.Count();
         if((count == 0) && \
((SymbianGlobalVideoParameters::Instance())->IsDisplayRegionValid()) == FALSE)  {


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs


[prev in list] [next in list] [prev in thread] [next in thread]