[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-common-dev
Subject:    RE: [Common-dev] CR: Added constructions and modified static_size()
From:       Li Qing <lqing () real ! com>
Date:       2010-10-14 1:34:32
Message-ID: 4A242CD46F4C34418D17941FF9746F97740027BB84 () SEAMBX ! corp ! real ! com
[Download RAW message or body]

Hi, Jeff.
I've discarded the modification, so you needn't worry about it.
Best Regards!
                           Li Qing
--
RealNetworks China, Beijing Office
Tel: 008601059542848
Fax: 008601085656477
Address: 18th Floor,Tower B,Pacific Century Place,2A GongTiBeiLu,Chaoyang \
District,Beijing, China Post Code: 100027
________________________________________
From: Jeff Leitner
Sent: Thursday, October 14, 2010 1:15 AM
To: Li Qing; common-dev@helixcommunity.org
Subject: RE: [Common-dev] CR: Added constructions and modified static_size() function \
for more safety (/common/include/rmfftype.h)

Can you please hold off on checking this in to hxclient_3_1_0_atlas as we are getting \
close to a product release?  We will be branching either on Friday or early next week \
and then it would be ok.  Thanks.

Jeff


-----Original Message-----
From: common-dev-bounces@helixcommunity.org \
                [mailto:common-dev-bounces@helixcommunity.org] On Behalf Of Li Qing
Sent: Wednesday, October 13, 2010 2:26 AM
To: common-dev@helixcommunity.org
Subject: [Common-dev] CR: Added constructions and modified static_size() function for \
more safety (/common/include/rmfftype.h)

Modified by: lqing@real.com
Date: 10/13/2010
Project: RealPlayer for Android Smartphones

Synopsis: Added constructions and modified static_size() function for more safety

Overview:
I found no construction in the classes which are declared in \
/common/include/rmfftype.h, it is not standard and may cause problems, so I added \
them. The return value of static_size() function is hard to understand and \
mistakable. Say, why does the AudioTypeSpecificData::static_size() function return \
73, not 79 or 83? So I modified them.

Files Added: None

Files Modified:
/common/include/rmfftype.h

Image Size and Heap Use impact (Client -Only): None

Platforms and Profiles Affected:
Platform:  android-donut3230-arm-qsd_8x50, android-2.2-arm-qsd_8250
Profile: helix-client-android-full

Distribution Libraries Affected:None

Distribution library impact and planned action: None

Platforms and Profiles Build Verified:
Platform: android-donut3230-arm-qsd_8x50
Profile: helix-client-android-full

Platforms and Profiles Functionality verified:
Platform: android-donut3230-arm-qsd_8x50

Profile: helix-client-android-full

Branch: HEAD, hxclient_3_1_0_atlas, hxclient_3_6_1_atlas, hxclient_3_6_2_atlas, \
hxclient_3_6_3_atlas

Copyright assignment: I am a RealNetworks employee or contractor


Best Regards!
                           Li Qing
--
RealNetworks China, Beijing Office
Tel: 008601059542848
Fax: 008601085656477
Address: 18th Floor,Tower B,Pacific Century Place,2A GongTiBeiLu,Chaoyang \
District,Beijing, China Post Code: 100027 \
_______________________________________________ Common-dev mailing list
Common-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/common-dev


[prev in list] [next in list] [prev in thread] [next in thread]