[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-common-dev
Subject:    RE: [Common-dev] CR:-Fix for initialized static data error in few
From:       <girish.shetty () nokia ! com>
Date:       2009-10-20 19:25:11
Message-ID: 888A0A0FAF11234F9E0D17809A78D7E411E8B05D58 () NOK-EUMSG-03 ! mgdnok ! nokia ! com
[Download RAW message or body]

Thanks Greg, 
CR checked-in to HEAD and BRIZO [420]

Regards
Girish


-----Original Message-----
From: ext Gregory Wright [mailto:gwright@real.com] 
Sent: Tuesday, October 20, 2009 12:01 PM
To: Shetty Girish (Nokia-D/Dallas)
Cc: client-dev@helixcommunity.org; common-dev@helixcommunity.org; \
server-dev@helixcommunity.org; nokia-private-dev@helixcommunity.org; \
                datatype-dev@helixcommunity.org
Subject: Re: [Common-dev] CR:-Fix for initialized static data error in few DLLs while \
building for ARMV5 UDEB using MMP Build system

Looks good.

--greg.



On Oct 20, 2009, at 8:12 AM, girish.shetty@nokia.com wrote:

> "Nokia submits this code under the terms of a commercial contribution 
> agreement with Real Networks, and I am authorized to contribute this 
> code under said agreement."
> 
> Modified by: girish.shetty@@nokia.com
> 
> Reviewed by:
> 
> Date: 10/19/2009
> 
> Project: phonon_backend
> 
> ErrorId: N/A
> 
> Synopsis: Fix for initialized static data error in few DLLs while 
> building for ARMV5 UDEB using MMP Build system
> 
> Overview: CVS ribosome build system uses elftran to generate E32Image 
> taking ABIv1 format and MMP build system uses elf2e32 to generate 
> E32Image taking (newer) ABIv2 format.
> Because of this [for difference in the image creation tool used and 
> the image creation options], when a DLL has global/static data, for 
> MMP build we get error reporting the presence of  global or static 
> data [which happens only for ARMV5 UDEB Debug MMP build]
> 
> This can be eliminated by mentioning "ALLOWEPOCDLLDATA" in the MMP 
> file.
> But, as these global/static data are used only for DEBUG version of 
> the DLL, such variables are made to be const to have consistency 
> between Release and Debug version of  the binaries.
> 
> In most of the files we have Debug specific code as below:
> 
> #ifdef _DEBUG
> #undef HX_THIS_FILE
> static const char HX_THIS_FILE[] = __FILE__; #endif
> 
> But in few files, this static global is declared as non-constant 
> because of which we get "initialized static data" error while creating 
> E32Image.
> So, the fix is to change all  such occurrences as static constant.
> 
> Files modified:
> client/encodesvc/common/util/hxtdirconv.cpp
> common/container/hxsbuffer.cpp
> common/log/logcommon/hlxxmlparser.cpp
> common/log/logcommon/hxtdirconv.cpp
> common/log/logobserverfile/hxtlogobserver.cpp
> common/log/logsystem/hxtdeliverymanager.cpp
> common/log/logsystem/hxtlogfaenumerator.cpp
> common/log/logsystem/hxtlogfilter.cpp
> common/log/logsystem/hxtlogqueue.cpp
> common/log/logsystem/hxtlogsystem.cpp
> common/log/logsystem/hxtthreadtracker.cpp
> common/log/logsystem/hxttranslationcentre.cpp
> common/log/logsystem/hxtwritermanager.cpp
> common/log/logsystem/logtest.cpp
> common/log/logsystem/platform/win/dllmain.cpp
> datatype/group/audio/audplin.cpp
> datatype/null/renderer/nullrend.cpp
> server/protocol/rtsp/nulltran.cpp
> 
> Files added: None
> 
> Image Size and Heap Use impact: None.
> 
> Module Release testing (STIF) : N/A
> 
> Test case(s) Added  : No
> 
> Memory leak check performed : Yes
> 
> Platforms and Profiles Build Verified: helix-client-s60-52-ng
> 
> Platforms and Profiles Functionality verified: armv5, winscw
> 
> Branch: HEAD, BRIZO
> 
> Diff:
> 
> 
> 
> <diff.txt>_______________________________________________
> Common-dev mailing list
> Common-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/common-dev


_______________________________________________
Common-dev mailing list
Common-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/common-dev


[prev in list] [next in list] [prev in thread] [next in thread]