[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-common-dev
Subject:    Re: [Common-dev] CR: common-module changes related to adding HTTPS
From:       Dean Collins <dcollins () real ! com>
Date:       2009-10-01 18:38:46
Message-ID: 20091001183846.GA8566 () dropzone ! prognet ! com
[Download RAW message or body]

Hi, Eric,

Yes, good question.  This was reviewed, and both the interface and
it's implentation appear to be client-oriented.  For example, the
IHXSecureSocket API provides SetClientCertificate() but no server
variation.  Also, the IHXSecureSocket implementation, CHXSecureSocket,
inherits from CHXClientSocket and relies on a ton of code in
client/common/netio, whereas we need to inherit from the server's
socket code.

Dean


On Wed, Sep 30, 2009 at 03:55:09PM -0400, M. Eric Hyche wrote:
> Dean,
>
> Did you guys take a look at the IHXSecureSocket implementation?
>
> It looks like you are implementing this differently from using 
> IHXSecureSocket.
>
> If so, can you describe how the server's SSL implemetation works?
>
> Eric
>
> On Sep 30, 2009, at 3:14 PM, Dean Collins wrote:
>
>> Synopsis
>> ========
>> CR: common-module changes related to adding HTTPS support for the Server's 
>> Admin System
>>
>> Branches: HEAD
>> Suggested Reviewer: Anyone
>>
>>
>> Description
>> ===========
>>
>> This diff enables HTTPS support for the Server's Admin system.
>> The majority of the code is outside common, so that what's in this diff
>> alone does not provide HTTPS support.  It is just necessary to allow
>> the server's HTTPS code to work.
>>
>> The underlying CHXSocket was hardly touched at all.  Some low-level
>> socket calls were made virtual so that we can override them in the
>> case of SSL.  A couple of flags were added.  Everything is #ifdef'd
>> HELIX_FEATURE_SERVER_SSL so there should be no effect on non-server
>> builds.
>>
>> Files Affected
>> ==============
>>
>> common/appext/vsrctag/vsrcrep.cpp
>> common/include/hxnet.h
>> common/netio/platform/posix/sockimp.cpp
>> common/netio/pub/platform/posix/sockimp.h
>>
>>
>> Testing Performed
>> =================
>>
>> Unit Tests:
>> - N/A.
>>
>> Integration Tests:
>> - Interacted with the Admin system over both HTTPS and HTTP ports.
>> - Interacted with the Help system over both HTTPS and HTTP ports
>>   (this provides several larger documents good for testing).
>>
>> Leak Tests:
>> - Not performed yet.
>>
>> Performance Tests:
>> - Not performed yet.
>>
>> Platforms Tested: linux-rhel5-i686, sunos-5.10-sparc-server, 
>> win32-i386-vc7
>> Build verified: linux-rhel5-i686, sunos-5.10-sparc-server, win32-i386-vc7
>>
>>
>> QA Hints
>> ========
>> * N/A
>>
>> <2009_09_25-server-ssl-common.diff>_______________________________________________
>> Common-dev mailing list
>> Common-dev@helixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/common-dev
>
> Eric Hyche (ehyche@real.com)
> Principal Engineer
> RealNetworks, Inc.
>
>

_______________________________________________
Common-dev mailing list
Common-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/common-dev
[prev in list] [next in list] [prev in thread] [next in thread]