[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-common-dev
Subject:    Re: [Common-dev] Re: CR: File creation fix for Android
From:       Sheldon Fu <sfu () real ! com>
Date:       2009-05-19 18:30:48
Message-ID: 1242757848.13988.5.camel () sfu6400
[Download RAW message or body]

Can you merge it to atlas310 too, since we are maintaining Android on
310 and may need file writing function for something else (caching e.g)
on that branch.

fxd

On Tue, 2009-05-19 at 10:33 -0700, Christina Bailey wrote:
> Thanks, Qiang.
> Checked into HEAD.
> --christina
> 
> Qiang Luo wrote:
> > The fix looks good to me.
> >
> > Qiang
> >
> > At 10:20 AM 5/19/2009, Christina Bailey wrote:
> >> Synopsis: File writers were not creating any files, because the low 
> >> level file io was not accounting for the open flags.
> >>
> >> Overview: Flip the create flag for files with the 'write' option.
> >>
> >> Branches: HEAD
> >>
> >> Diff:
> >>
> >> Index: platform/android/fdbufdataf.cpp
> >> ===================================================================
> >> RCS file: /cvsroot/common/fileio/platform/android/fdbufdataf.cpp,v
> >> retrieving revision 1.1
> >> diff -w -u -5 -r1.1 fdbufdataf.cpp
> >> --- platform/android/fdbufdataf.cpp    2 Mar 2009 17:23:01 -0000    1.1
> >> +++ platform/android/fdbufdataf.cpp    19 May 2009 16:11:55 -0000
> >> @@ -152,13 +152,19 @@
> >> }
> >> STDMETHODIMP
> >> FDBufferedDataFile::Open(UINT16 uOpenMode)
> >> {
> >> -    return _Create(uOpenMode, FALSE);
> >> +    HXBOOL bCreate=FALSE;
> >> +    if (uOpenMode & HX_FILE_WRITE)
> >> +    {
> >> +    bCreate = TRUE;
> >> +    }
> >> +    return _Create(uOpenMode, bCreate);
> >> }
> >
> >
> >
> 
> _______________________________________________
> Common-dev mailing list
> Common-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/common-dev


_______________________________________________
Common-dev mailing list
Common-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/common-dev
[prev in list] [next in list] [prev in thread] [next in thread]