[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-common-dev
Subject:    [Common-dev] COMMIT: FMLK-7NF7CS wrong popup message in realplayer
From:       <ext-jose-antonio.2.zamora () nokia ! com>
Date:       2009-02-27 17:51:42
Message-ID: B26CC1CBE7B84E4DAC8886E1C12FB38001184D51 () xesebe102 ! nee ! nokia ! com
[Download RAW message or body]

Committed to 221Cayennes, 210Cayennes and Head.

Br,
Jose

________________________________

From: ext Greg Wright [mailto:gwright@real.com]
Sent: Fri 2/27/2009 7:15 PM
To: Zamora Jose-Antonio.2 (EXT-Dextra-MSW/Mexico)
Cc: common-dev@helixcommunity.org; nokia-private-dev@helixcommunity.org
Subject: Re: [Nokia-private-dev] CR: FMLK-7NF7CS wrong popup message in realplayer



Looks good.
--greg.


ext-jose-antonio.2.zamora@nokia.com wrote:
> "Nokia submits this code under the terms of a commercial contribution agreement \
> with RealNetworks, and I am authorized to contribute this code under said \
> agreement." 
> Modified by:  ext-jose-antonio.2.zamora@nokia.com
> 
> Reviewed by:
> 
> TSW Id: FMLK-7NF7CS
> 
> Date: 26/02/2009
> 
> Project: SymbianMmf_rel
> 
> Synopsis: wrong popup message in realplayer.
> 
> Overview:
> In method CHXMiniFileObject::DoReadLoopEx() If no byte is available because the \
> file is empty then DoReadDone() is invoked with status HXR_READ_ERROR which \
> eventually calls CHXFileRecognizer::ReadDone. In method ReadDone() If status is \
> HXR_READ_ERROR then GetMimeTypeDone() is invoked with status HXR_FAIL which \
> ultimately reaches to Helix Controller. Since HXR_FAIL is a generic error, there is \
> no context of this error on Player side and so it reports General System Error. 
> Fix:
> Helix needs to distinguish if the problem is caused by an invalid file or some \
> other error, one way of achieving this is to make GetMimeTypeDone() pass the error \
> code as it is instead of HXR_FAIL. 
> Files modified & changes:
> common/system/recognizer.cpp
> 
> --- system/recognizer.cpp 19 Sep 2006 21:04:33 -0000 1.11.8.1
> +++ system/recognizer.cpp 26 Feb 2009 18:21:03 -0000
> @@ -175,7 +175,7 @@
> {
> if (FAILED(status) && m_pResponse)
> {
> - m_pResponse->GetMimeTypeDone(HXR_FAIL, NULL);
> + m_pResponse->GetMimeTypeDone(status, NULL);
> }
> else
> {
> 
> Image Size and Heap Use impact: None
> 
> Module Release testing (STIF, Audio) : Passed
> 
> Test case(s) Added  : No
> 
> Memory leak check performed : Passed, No leaks found
> 
> Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-arm
> helix-client-s60-32-mmf-mdf-arm
> 
> Platforms and Profiles Functionality verified: armv5
> 
> Branch: 210Cays, 221Cays, head
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Nokia-private-dev mailing list
> Nokia-private-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/nokia-private-dev




_______________________________________________
Common-dev mailing list
Common-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/common-dev


[prev in list] [next in list] [prev in thread] [next in thread]