[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-common-dev
Subject:    RE: [Common-dev] CR needed: helix cvs symbian wincsw emulator build
From:       <Yury.Ramanovich () nokia ! com>
Date:       2009-02-27 16:46:18
Message-ID: BE808F92D8B85A4FB9A6D26B46CB39EC155C24DA12 () NOK-EUMSG-03 ! mgdnok ! nokia ! com
[Download RAW message or body]

Thanks Greg, this change has been checked in to ribosome

Yury

>-----Original Message-----
>From: ext Greg Wright [mailto:gwright@real.com]
>Sent: Thursday, February 26, 2009 6:25 PM
>To: Ramanovich Yury (Nokia-D-MSW/Dallas)
>Cc: nokia-private-dev@helixcommunity.org; common-dev@helixcommunity.org
>Subject: Re: [Common-dev] CR needed: helix cvs symbian wincsw
>emulator build break
>
>Looks good.
>--greg.
>
>Yury.Ramanovich@nokia.com wrote:
>> Modified by: yury.ramanovich@nokia.com Reviewed by:
>>
>> Date: 02/25/2009
>> Project: SymbianMmf_wm
>>
>> ErrorId: N/A
>> Synopsis: helix cvs symbian wincsw emulator build break
>caused by name
>> clash with  /epoc32/include/platform/mw/debug.h
>> Overview: on MCL 5.1 SDK there is /epoc32/include/platform/mw/debug.h
>> file from some other component. When building helix cvs for winscw
>> target, this file gets included in the build instead of
>> /common/dbgtool/pub/debug.h, because /epoc32/include/platform/wm dir
>> is prior to /common/dbgtool/pub dir on the search path. The
>end result
>> is that DPRINTF , DREGISTRY and similar macros are undefined
>and build
>> break occurs.
>> This doesn't affect winscw .mmp style build, because system include
>> dirs and user include dirs ( module dirs) are specified via
>> SYSTEMINCLUDE and USERINCLUDE macros and makmake tool processes them
>> correctly placing USERINCLUDE dirs  prior to SYSTEMINCLUDE dirs in
>> INCDIR search path in generated .WINCSW makefile.
>> Solution: Module includes are in $(INCLUDES) variable in Makefile
>> generated during helix cvs winscw build. Currently $(INCLUDES) is
>> appended after system include dirs in CCFLAGS or CXXFLAGS
>variables in
>> the generated Makefile. We need to ensure that module includes are
>> searched first before system includes:
>> 1) Prepend $(INCLUDES) variable in the front of system
>include dirs in
>> SymbianCompiler.__init__ method.
>> 2) Override base Compiler.setup_flags_var method in derived
>> SymbianCompiler class to make sure $(INCLUDES) variable doesn't get
>> added twice to CCFLAGS and CXXFLAGS in the generated Makefile.
>> Files modified:
>> /build/umakecf/symbian-emulator-winscw.cf
>> Files added:
>> None.
>> Image Size and Heap Use impact: minor
>> Module Release testing (STIF) : yes
>> Test case(s) Added : No
>>
>> Memory leak check performed : Yes. No new memory leaks introduced.
>>
>> Platforms and Profiles Build Verified:
>helix-client-s60-50-mmf-mdf-arm
>> Platforms and Profiles Functionality verified: armv5, winscw
>>
>> Branch: 210Cays, HEAD
>>
>>
>>
>>
>>
>----------------------------------------------------------------------
>> --
>>
>> _______________________________________________
>> Common-dev mailing list
>> Common-dev@helixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/common-dev
>
>

_______________________________________________
Common-dev mailing list
Common-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/common-dev

[prev in list] [next in list] [prev in thread] [next in thread]