[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-common-dev
Subject:    [Common-dev] CR: FMLK-7NF7CS wrong popup message in realplayer
From:       <ext-jose-antonio.2.zamora () nokia ! com>
Date:       2009-02-26 21:30:21
Message-ID: B26CC1CBE7B84E4DAC8886E1C12FB38001184D4F () xesebe102 ! nee ! nokia ! com
[Download RAW message or body]

"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."  
Modified by:  ext-jose-antonio.2.zamora@nokia.com
 
Reviewed by:
 
TSW Id: FMLK-7NF7CS
 
Date: 26/02/2009
 
Project: SymbianMmf_rel
 
Synopsis: wrong popup message in realplayer.
 
Overview:
In method CHXMiniFileObject::DoReadLoopEx() If no byte is available because the file \
is empty then DoReadDone() is invoked with status HXR_READ_ERROR which eventually \
calls CHXFileRecognizer::ReadDone. In method ReadDone() If status is HXR_READ_ERROR \
then GetMimeTypeDone() is invoked with status HXR_FAIL which ultimately reaches to \
Helix Controller. Since HXR_FAIL is a generic error, there is no context of this \
error on Player side and so it reports General System Error.  
Fix:
Helix needs to distinguish if the problem is caused by an invalid file or some other \
error, one way of achieving this is to make GetMimeTypeDone() pass the error code as \
it is instead of HXR_FAIL.  
Files modified & changes:
common/system/recognizer.cpp
 
--- system/recognizer.cpp 19 Sep 2006 21:04:33 -0000 1.11.8.1
+++ system/recognizer.cpp 26 Feb 2009 18:21:03 -0000
@@ -175,7 +175,7 @@
 {
     if (FAILED(status) && m_pResponse)
     {
- m_pResponse->GetMimeTypeDone(HXR_FAIL, NULL);
+ m_pResponse->GetMimeTypeDone(status, NULL);
     }
     else
     {
 
Image Size and Heap Use impact: None
 
Module Release testing (STIF, Audio) : Passed
 
Test case(s) Added  : No
 
Memory leak check performed : Passed, No leaks found
 
Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-arm
                                                      helix-client-s60-32-mmf-mdf-arm
 
Platforms and Profiles Functionality verified: armv5
 
Branch: 210Cays, 221Cays, head


["common.diff" (text/plain)]

? common.diff
? container/Makefile
? container/Umakefil.upp
? container/armv5-dbg32
? container/ucontlib.mak
? container/ucontlib.upp
? dbgtool/Makefile
? dbgtool/Umakefil.upp
? dbgtool/armv5-dbg32
? fileio/Makefile
? fileio/Umakefil.upp
? fileio/armv5-dbg32
? lang/xml/Makefile
? lang/xml/Umakefil.upp
? lang/xml/armv5-dbg32
? lang/xml/hxxml_dll_stub.c
? lang/xml/hxxml_ordinal.dat
? lang/xml/hxxml{000a0000}.def
? lang/xml/xmldll.mak
? lang/xml/xmldll.upp
? lang/xml/xmllib.mak
? lang/xml/xmllib.upp
? log/logcommon/Makefile
? log/logcommon/Umakefil.upp
? log/logcommon/armv5-dbg32
? log/logobserverfile/Makefile
? log/logobserverfile/Umakefil.upp
? log/logobserverfile/armv5-dbg32
? log/logobserverfile/logobserverfile_dll_stub.c
? log/logobserverfile/logobserverfile_ordinal.dat
? log/logobserverfile/logobserverfile{000a0000}.def
? log/logsystem/Makefile
? log/logsystem/Umakefil.upp
? log/logsystem/armv5-dbg32
? log/logsystem/hxtlogdll.mak
? log/logsystem/hxtlogdll.upp
? log/logsystem/log_dll_stub.c
? log/logsystem/log_ordinal.dat
? log/logsystem/log{000a0000}.def
? log/logutil/Makefile
? log/logutil/Umakefil.upp
? log/logutil/armv5-dbg32
? netio/Makefile
? netio/Umakefil.upp
? netio/armv5-dbg32
? runtime/Makefile
? runtime/Umakefil.upp
? runtime/armv5-dbg32
? system/Makefile
? system/Umakefil.upp
? system/armv5-dbg32
? util/Makefile
? util/Umakefil.upp
? util/armv5-dbg32
Index: include/platform.h
===================================================================
RCS file: /cvsroot/common/include/platform.h,v
retrieving revision 1.34.2.3
diff -u -w -r1.34.2.3 platform.h
--- include/platform.h	7 Dec 2007 19:29:02 -0000	1.34.2.3
+++ include/platform.h	16 Feb 2009 17:09:15 -0000
@@ -50,5 +50,5 @@
 #ifndef _PLATFORM_H_

 #define _PLATFORM_H_

 #define TARVER_STR_PLATFORM "symbian"

-#define TARVER_STR_BUILD_BRANCH "hxclient_2_1_0_cayennes_restricted"

+#define TARVER_STR_BUILD_BRANCH "hxclient_2_2_1_cayennes_restricted"
 #endif

Index: system/recognizer.cpp
===================================================================
RCS file: /cvsroot/common/system/recognizer.cpp,v
retrieving revision 1.11.8.1
diff -u -w -r1.11.8.1 recognizer.cpp
--- system/recognizer.cpp	19 Sep 2006 21:04:33 -0000	1.11.8.1
+++ system/recognizer.cpp	26 Feb 2009 18:21:03 -0000
@@ -175,7 +175,7 @@
 {
     if (FAILED(status) && m_pResponse)
     {
-	m_pResponse->GetMimeTypeDone(HXR_FAIL, NULL);
+	m_pResponse->GetMimeTypeDone(status, NULL);
     }
     else
     {


_______________________________________________
Common-dev mailing list
Common-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/common-dev


[prev in list] [next in list] [prev in thread] [next in thread]