[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-common-cvs
Subject: [Common-cvs] log/logutil/pub/platform/symbian
From: amsaleem () helixcommunity ! org
Date: 2010-03-17 21:07:18
Message-ID: 201003172107.o2HL7frq003866 () mailer ! progressive-comp ! com
[Download RAW message or body]
Update of /cvsroot/common/log/logutil/pub/platform/symbian
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv9031
Modified Files:
Tag: hxclient_4_2_0_brizo
hxsymlogsystemmanager.h
Log Message:
"Nokia submits this code under the terms of a commercial contribution agreement with \
Real Networks, and I am authorized to contribute this code under said agreement."
Modified by: saleem.adookkattil@nokia.com
Reviewed by:
Date: 03/16/2010
Project: symbian_client_apps
ErrorId: JLIU_83KSM1
Synopsis: Fixed condition to enable logging and log manager instance release.
Overview:
Made the following changes.
1) Existing code on failure to read value of 'Logging\\File\\Enabled' from \
configuration enables logging. Fixed this one by setting not to enable logging on \
failure to read the value.
2) Releasing instance of m_pLogSystemManager inside CHXMediaPlatform before releasing \
plugins those hold reference to logsystem cause crash on sybian platform. Made fix \
to release m_pLogSystemManager instance after releasing all loaded plugins.
3) Symbian TLC context call close on log manager even if the context instance not \
intialized the logging.This causes multiple close method call on log manager. \
Corrected this problem by introducing a member variable m_bTerminateLogging and check \
whether instance received call to initialize logging. In addition made changes to \
call log system manager interface methods instead of directly calling symbian log \
manger method close. Also made some code cleanup inside symbian tlc cotext.
Files modified:
cvsroot\client\medpltfm\chxmedpltfm.cpp
cvsroot\common\log\logutil\platform\symbian\hxsymlogsystemmanager.cpp
cvsroot\common\log\logutil\pub\platform\symbian\hxsymlogsystemmanager.h
cvsroot\common\system\platform\symbian\symbian_tlc_context.cpp
cvsroot\common\system\pub\platform\symbian\symbian_tlc_context.h
Files added:
Image Size and Heap Use impact: None.
Module Release testing (STIF) : Yes
Test case(s) Added : No
Memory leak check performed : Yes
Platforms and Profiles Build Verified: helix-client-symbian-4
Platforms and Profiles Functionality verified: armv5, winscw
Branch: 4_2_0_brizo, HEAD
Index: hxsymlogsystemmanager.h
===================================================================
RCS file: /cvsroot/common/log/logutil/pub/platform/symbian/hxsymlogsystemmanager.h,v
retrieving revision 1.2
retrieving revision 1.2.4.1
diff -u -d -r1.2 -r1.2.4.1
--- hxsymlogsystemmanager.h 25 Jun 2009 14:06:40 -0000 1.2
+++ hxsymlogsystemmanager.h 17 Mar 2010 21:07:16 -0000 1.2.4.1
@@ -103,6 +103,9 @@
CHXSymLogSystemManager();
virtual ~CHXSymLogSystemManager();
+private:
+ INT16 m_sLogSystemInitCount;
+
//make CHXLogSystemManager as friend so that it can construct this class object \
in the factory function friend class CHXLogSystemManager;
};
_______________________________________________
Common-cvs mailing list
Common-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/common-cvs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic