[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-clientapps-dev
Subject:    Re: [Nokia-private-dev] RE: [Clientapps-dev] URGENT CR: JAVA TCK:
From:       Qiang Luo <qluo () real ! com>
Date:       2010-05-31 13:42:20
Message-ID: 4C03BCBC.409 () real ! com
[Download RAW message or body]

Looks good.

Qiang

On 5/31/2010 5:42 AM, ext-anugrah.2.kashari@nokia.com wrote:
> Any comments on this?
> 
> -----Original Message-----
> From: clientapps-dev-bounces@helixcommunity.org \
> [mailto:clientapps-dev-bounces@helixcommunity.org] On Behalf Of Mishra Sudhir.1 \
>                 (EXT-Sasken/Dallas)
> Sent: Saturday, May 29, 2010 2:03 AM
> To: clientapps-dev@helixcommunity.org; nokia-private-dev@helixcommunity.org; \
>                 Ramanovich Yury (Nokia-D/Dallas)
> Subject: [Clientapps-dev] URGENT CR: JAVA TCK: JSR135 MMAPI: SetRate tests failed \
> with FL_Video(01).dcf 
> 
> Nokia submits this code under the terms of a commercial contribution agreement with \
> RealNetworks, and I am authorized to contribute this code under said agreement." 
> Modified by: ext-anugrah.2.kashari@nokia.com
> 
> Reviewed by: Yury.Ramanovich@nokia.com
> 
> TSW Id: EWJG-85N4HQ
> 
> Date: 05/28/2010
> 
> Project: SymbianMmf_wm
> 
> Synopsis:  JAVA TCK: JSR135 MMAPI: SetRate tests failed with FL_Video(01).dcf
> 
> Overview:  The use case for this is Play->Pause->Stop->Play. When application tries \
> to start playback second time HXMMFCtrlImpl::PlayL() leaves with KErrNotReady(-18). \
> The leave occurs when CMMFFile::ExecuteIntent() is called with m_DRMIntent which \
> was set to ContentAccess::TIntent::EContinue during pause. When application call \
> StopL(), m_nextEvent is set to Event::ErrorEvent so OnPresentationClosed() \
> m_DRMIntent remains unchanged. 
> Fix: In OnPresentationClosed(), m_DRMIntent should be changed to \
> ContentAccess::TIntent::EPlay irrespective of m_nextEvent. Same changes are needed \
> for audio controller. 
> Files modified&  changes:
> /clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp	
> /clientapps/symbianMmf/audiocontroller/hxmmfaudioctrl.cpp
> 
> Image Size and Heap Use impact: No major impact
> 
> Module Release testing (STIF) : Done
> 
> Test case(s) Added  : No
> 
> Memory leak check performed : Passed, No additional leaks introduced.
> 
> Platforms and Profiles Build Verified: helix-client-s60-52-mmf-mdf-dsp
> 
> Platforms and Profiles Functionality verified: armv5
> 
> Branch: 210CayS, 420Bizo and HEAD
> 
> Index: hxmmfctrlimpl.cpp
> ===================================================================
> RCS file: /cvsroot/clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp,v
> retrieving revision 1.12.2.79
> diff -u -w -r1.12.2.79 hxmmfctrlimpl.cpp
> --- hxmmfctrlimpl.cpp   20 May 2010 16:33:30 -0000      1.12.2.79
> +++ hxmmfctrlimpl.cpp   28 May 2010 06:08:45 -0000
> @@ -1297,11 +1297,10 @@
> m_pDataSource->Seek(0, SEEK_SET);
> }
> 
> +    m_DRMIntent = ContentAccess::EPlay;
> 
> if ( m_nextEvent == PlaybackComplete )
> {
> -        m_DRMIntent = ContentAccess::EPlay;
> -
> if(m_closePlayer)
> {
> HXLOGL1(HXLOG_SMMF, "HXMMFCtrlImpl::OnPresentationClosed(System out of Memory)");
> 
> Index: hxmmfaudioctrl.cpp
> ===================================================================
> RCS file: /cvsroot/clientapps/symbianMmf/audiocontroller/hxmmfaudioctrl.cpp,v
> retrieving revision 1.1.2.35
> diff -u -w -r1.1.2.35 hxmmfaudioctrl.cpp
> --- hxmmfaudioctrl.cpp  20 May 2010 16:33:02 -0000      1.1.2.35
> +++ hxmmfaudioctrl.cpp  28 May 2010 06:10:16 -0000
> @@ -812,9 +812,10 @@
> m_pDataSource->Seek(0, SEEK_SET);
> }
> 
> +    m_DRMIntent = ContentAccess::EPlay;
> +
> if ( m_nextEvent == PlaybackComplete )
> {
> -        m_DRMIntent = ContentAccess::EPlay;
> if(m_closePlayer)
> {
> HXLOGL1(HXLOG_SMMF, "CHXAudioController::OnPresentationClosed(System out of \
> Memory)"); 
> _______________________________________________
> Clientapps-dev mailing list
> Clientapps-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/clientapps-dev
> 
> _______________________________________________
> Nokia-private-dev mailing list
> Nokia-private-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/nokia-private-dev
> .
> 
> 


_______________________________________________
Clientapps-dev mailing list
Clientapps-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/clientapps-dev


[prev in list] [next in list] [prev in thread] [next in thread]