[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-clientapps-dev
Subject: [Clientapps-dev] CR: MMF controller failure to handle resource
From: <saleem.adookkattil () nokia ! com>
Date: 2008-03-27 23:26:58
Message-ID: 7034F9AABBF1CF47A594E190401492F701044F5F () daebe103 ! NOE ! Nokia ! com
[Download RAW message or body]
--===============0016759430==
Content-class: urn:content-classes:message
Content-Type: multipart/alternative;
boundary="----_=_NextPart_001_01C89062.0DA7D786"
This is a multi-part message in MIME format.
> "Nokia submits this code under the terms of a commercial contribution
> agreement
> with RealNetworks, and I am authorized to contribute this code under
> said agreement."
>
> Modified by: saleem.adookkattil@nokia.com
>
> Reviewed by:
>
> Date: 27-March-2008
>
> Project: SymbianMmf_Rel
>
> TSW: EMKD-7CWKEC
>
> Synopsis: Fix to correct MMF controller failure to handle resource
> lost/restored events in closed state.
>
> Overview: Upon completion of the play back MMF controller set the
> state to close. If the player uses DSP decoder to decode the video
> content MMF controller may get a resource lost/restored event from the
> video adapter at any state. MMF controller doesn't handle these events
> in closed state and forward it to higher level to handle it after
> changing the MM state to error state. As the state is closed there is
> no need to report it to higher level or change the state of controller
> to error state. Fix made as given in the diff file.
>
> Files Modified:
>
> /cvsroot/clientapps/symbianMmf/hxmmfstateclosed.cpp
>
> Image Size and Heap Use impact: None
>
> Module Release testing (STIF) : Pass
>
> Test case(s) Added : No
>
> Memory leak check performed : No new leaks introduced.
>
> Platforms and Profiles Build Verified:
> Profile -> helix-client-s60-32-mmf-mdf-arm
> BIF branch -> helix_restricted
> SYSTEM_ID -> symbian-91-armv5
> Target -> symbianMmf_rel
>
> Platforms and Profiles Functionality verified: armv5, winscw
>
> Branch: 210CayS, 221CayS& head
>
> Index: hxmmfstateclosed.cpp
> ===================================================================
> RCS file: /cvsroot/clientapps/symbianMmf/hxmmfstateclosed.cpp,v
> retrieving revision 1.3.2.7
> diff -u -w -r1.3.2.7 hxmmfstateclosed.cpp
> --- hxmmfstateclosed.cpp 21 Jun 2007 16:50:30 -0000 1.3.2.7
> +++ hxmmfstateclosed.cpp 27 Mar 2008 20:05:43 -0000
> @@ -176,10 +176,12 @@
> HXLOGL2(HXLOG_SMMF, "HXMMFStateClosed::ErrorOccurred");
>
> //
> - // Partial Playback error is consumed here so return KErrNone.
> + // Consume errors those are not an error at close state here and
> return KErrNone.
> // Otherwise, pass error up since we are in the closed state
> //
> - if (ulHXCode == HXR_PARTIALPLAYBACK)
> + if (ulHXCode == HXR_PARTIALPLAYBACK ||
> + ulHXCode == HXR_DEVVIDEO_RESOURCE_RESTORED ||
> + ulHXCode == HXR_DEVVIDEO_RESOURCE_LOST)
> {
> return KErrNone;
> }
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7653.3">
<TITLE>CR: MMF controller failure to handle resource lost/restored error events in \
closed state</TITLE> </HEAD>
<BODY>
<!-- Converted from text/rtf format -->
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">"Nokia submits this code under the \
terms of a commercial contribution agreement</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">with RealNetworks, and I am authorized \
to contribute this code under said agreement."</FONT> </P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">Modified by: \
saleem.adookkattil@nokia.com</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> </FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">Reviewed by: </FONT>
</P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">Date: 27-March-2008</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> </FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">Project: SymbianMmf_Rel </FONT>
</P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">TSW: EMKD-7CWKEC</FONT>
</P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">Synopsis: Fix to correct MMF controller \
failure to handle resource lost/restored events in closed state.</FONT> </P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">Overview: Upon completion of the play \
back MMF controller set the state to close. If the player uses DSP decoder to decode \
the video content MMF controller may get a resource lost/restored event from the \
video adapter at any state. MMF controller doesn't handle these events in closed \
state and forward it to higher level to handle it after changing the MM state to \
error state. As the state is closed there is no need to report it to higher level or \
change the state of controller to error state. Fix made as given in the diff \
file.</FONT></P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial"> </FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">Files Modified:</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> </FONT>
<BR><FONT COLOR="#000000" SIZE=2 \
FACE="Arial">/cvsroot/clientapps/symbianMmf/hxmmfstateclosed.cpp</FONT> </P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">Image Size and Heap Use impact: \
None</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> </FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">Module Release testing (STIF) : \
Pass</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> </FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">Test case(s) Added : \
No</FONT> </P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">Memory leak check performed : No new \
leaks introduced. </FONT> </P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">Platforms and Profiles Build Verified: \
</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">Profile -> \
helix-client-s60-32-mmf-mdf-arm</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">BIF branch -> \
helix_restricted</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">SYSTEM_ID -> symbian-91-armv5</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">Target -> symbianMmf_rel</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> </FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">Platforms and Profiles Functionality \
verified: armv5, winscw</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> </FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">Branch: 210CayS, 221CayS& \
head</FONT> </P>
<P><FONT COLOR="#000000" SIZE=2 FACE="Arial">Index: hxmmfstateclosed.cpp</FONT>
<BR><FONT COLOR="#000000" SIZE=2 \
FACE="Arial">===================================================================</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">RCS file: \
/cvsroot/clientapps/symbianMmf/hxmmfstateclosed.cpp,v</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">retrieving revision 1.3.2.7</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">diff -u -w -r1.3.2.7 \
hxmmfstateclosed.cpp</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">--- \
hxmmfstateclosed.cpp 21 Jun 2007 16:50:30 \
-0000 1.3.2.7</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">+++ \
hxmmfstateclosed.cpp 27 Mar 2008 20:05:43 \
-0000</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">@@ -176,10 +176,12 @@</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> \
HXLOGL2(HXLOG_SMMF, "HXMMFStateClosed::ErrorOccurred");</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> </FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> // </FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">- // Partial \
Playback error is consumed here so return KErrNone.</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">+ // Consume errors \
those are not an error at close state here and return KErrNone.</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> // \
Otherwise, pass error up since we are in the closed state</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> //</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">- if (ulHXCode == \
HXR_PARTIALPLAYBACK)</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial">+ if (ulHXCode == \
HXR_PARTIALPLAYBACK ||</FONT>
<BR><FONT COLOR="#000000" SIZE=2 \
FACE="Arial">+ ulHXCode == \
HXR_DEVVIDEO_RESOURCE_RESTORED ||</FONT>
<BR><FONT COLOR="#000000" SIZE=2 \
FACE="Arial">+ ulHXCode == \
HXR_DEVVIDEO_RESOURCE_LOST)</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> {</FONT>
<BR><FONT COLOR="#000000" SIZE=2 \
FACE="Arial"> return KErrNone;</FONT>
<BR><FONT COLOR="#000000" SIZE=2 FACE="Arial"> }</FONT>
</P>
</BODY>
</HTML>
_______________________________________________
Clientapps-dev mailing list
Clientapps-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/clientapps-dev
--===============0016759430==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic