[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-clientapps-cvs
Subject: [Clientapps-cvs] symbianMmf/videocontroller hxmmfctrlimpl.cpp,
From: anuj_dhamija () helixcommunity ! org
Date: 2008-06-03 22:50:03
Message-ID: 200806032250.m53MonTU015196 () mailer ! progressive-comp ! com
[Download RAW message or body]
Update of /cvsroot/clientapps/symbianMmf/videocontroller
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv24546
Modified Files:
Tag: hxclient_2_2_1_cayennes
hxmmfctrlimpl.cpp
Log Message:
"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."
Modified by: ext-anuj.dhamija@nokia.com
Reviewed by:
Date: 06/03/2008
Project: SymbianMmf_rel
Synopsis: Audio-Video Clip with missing bitrate info in SDP recognized as Audio Only \
Clip
Overview:
UI uses bitrate info to verify if a clip has Video Stream. If bitrate is zero, it \
assumes a Audio-only clip and paints a partial playback screen. Some servers do not \
send bitrate info for video stream in SDP [Missing b=AS parameter] even though there \
is a video stream present. Missing bitrate causes UI to assume that video stream is \
missing and so it displays a partial playback screen and video is not rendered.
Fix:
If video stream is present and it has a non-null renderer associated (i.e. it is \
going to be rendered) then return a default video bitrate if no video bitrate is \
received in SDP for the clip (i.e. if video bitrate is zero).
Files modified & changes:
clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp
Image Size and Heap Use impact: None
Module Release testing (STIF, Audio) : Passed
Test case(s) Added : No
Memory leak check performed : Passed, No leaks found
Platforms and Profiles Build Verified: helix-client-s60-32-mmf-mdf-arm
Platforms and Profiles Functionality verified: armv5
Branch: Head, 210CayS, 221Cays
Index: hxmmfctrlimpl.cpp
===================================================================
RCS file: /cvsroot/clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp,v
retrieving revision 1.12.2.58.2.2
retrieving revision 1.12.2.58.2.3
diff -u -d -r1.12.2.58.2.2 -r1.12.2.58.2.3
--- hxmmfctrlimpl.cpp 26 Mar 2008 20:45:57 -0000 1.12.2.58.2.2
+++ hxmmfctrlimpl.cpp 3 Jun 2008 22:50:00 -0000 1.12.2.58.2.3
@@ -87,6 +87,8 @@
// Minimum memory needed to start controller
//
static const int KMinStartupMemory = 4000*1024;
+//Default Video Bitrate for servers not sending bit rate in SDP
+#define KDefaultAverageVideoBitRate 150000
////////////////////////////////////////////////
@@ -926,6 +928,10 @@
{
m_pMetaData->FindStreamValueByName( "Video", "AvgBitRate", aBitRate );
+ if(0==aBitRate)
+ {
+ aBitRate = KDefaultAverageVideoBitRate;
+ }
}
}
else
@@ -933,6 +939,8 @@
HXLOGL1(HXLOG_SMMF, "HXMMFCtrlImpl::MvcGetVideoBitRateL ERROR LEAVE: \
KErrNotReady"); User::Leave(KErrNotReady);
}
+
+ HXLOGL2(HXLOG_SMMF, "HXMMFCtrlImpl::MvcGetVideoBitRateL BitRate is : %d", \
aBitRate); }
void
_______________________________________________
Clientapps-cvs mailing list
Clientapps-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/clientapps-cvs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic