[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-clientapps-cvs
Subject:    [Clientapps-cvs]
From:       rrajesh () helixcommunity ! org
Date:       2007-08-16 19:27:09
Message-ID: 200708161927.l7GJRfPq007608 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/clientapps/symbianMmf/videocontroller
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv29622/videocontroller

Modified Files:
	hxmmfctrlimpl.cpp 
Log Message:
> 
> 	"Nokia submits this code under the terms of a commercial contribution 
> agreement with RealNetworks, and I am authorized to contribute this 
> code under said agreement."
> 
> 		Modified by:  rajesh.rathinasamy@nokia.com
> 
> 		Reviewed by: 
> 
> 		Date: 13-Aug-2007
> 
> 		Project: SymbianMmf
> 
> 	      ErrorId: RRAY-765NTW
> 
> 		            
> 		Synopsis:  CR: Create log system from MMFController instead of 
> client engine startup
> 
> 		Symbian builds uses Core logging and it is created and enabled when 
> engine is created and initialised.
> Delay in log system being loaded hinders in debugging problems in MMF 
> Controller and MDF plugin archive creation.
> 
> 		Solution proposed in this CR is to load the log system from MMF 
> Controller and override the engine's service with the provided log 
> system. Still this does not solve the problem of debug statements 
> during GetRendererInfo as the plugin is not initialized. To overcome 
> that problem for symbian, the log system is created in MMF controller 
> and stored in GlobalManager. Since we don't need any Context to 
> initialize log for each dll, the initialization has been added to the 
> logging api (HXLOGx). When Logging is available on GlobalMgr, the 
> first log statement in every dll will initialize the log system 
> variables for that dll.
> 
> 		Previous core logging functionality is still valid after this 
> change.  Any symbian platform (eg.,
> symbianplayer) can take advantage of both.
> 
> 		  
> 		Root Cause of the problem: Design
> 		  
> 		Files Modified: 
> 		common/log/logutil/hxtlogutil.cpp 
> 		common/log/logutil/pub/hxtlogutil.h 
> 		common/system/pub/platform/symbian/symbian_gm_inst.h
> 
> 		client/core/hxcleng.cpp   (Changed the variable 
> name and log system shutdown is made conditional based on whether 
> engine created it or not)
> 
> 		client/core/pub/hxcleng.h
> 
> 		clientapps/symbianMmf/MmfCtrlLib 
> 		clientapps/symbianMmf/hxmmfplayctrl.cpp 
> 		clientapps/symbianMmf/hxmmfplayctrl.h 
> 		clientapps/symbianMmf/hxmmfstatectrl.cpp 
> 		clientapps/symbianMmf/hxmmfstatectrl.h
> 		
> clientapps/symbianMmf/audiocontroller/hxmmfaudioctrl.cpp 
> 		clientapps/symbianMmf/common/hxmmfbasectrl.cpp 
> 		clientapps/symbianMmf/common/hxmmfbasectrl.h 
> 		clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp
> 
> 		Files Added: 
> 		Common/log/logutil/symbian.pcf 
> 		Clientapps/symbianmmf/hxmmfcontext.h 
> 		Clientapps/symbianmmf/hxmmfcontext.cpp
> 
> 		Image Size and Heap Use impact: no major impact
> 
> 		Module Release testing (STIF) :  Passed. 
> 
> 		Test case(s) Added  :  No. 
> 
> 		Memory leak check performed : Yes.  No new leaks introduced.
> 
> 		Platforms and Profiles Build Verified: 
> helix-client-s60-32-mmf-mdf-arm
> 
> 		Platforms and Profiles Functionality verified: 
> armv5,winscw


Index: hxmmfctrlimpl.cpp
===================================================================
RCS file: /cvsroot/clientapps/symbianMmf/videocontroller/hxmmfctrlimpl.cpp,v
retrieving revision 1.69
retrieving revision 1.70
diff -u -d -r1.69 -r1.70
--- hxmmfctrlimpl.cpp	15 Aug 2007 22:27:27 -0000	1.69
+++ hxmmfctrlimpl.cpp	16 Aug 2007 19:27:06 -0000	1.70
@@ -155,6 +155,7 @@
     }
 
     HX_RELEASE(m_pStateCtrl);
+    HX_RELEASE(m_pMMFContext);
     HX_DELETE(m_pEnvChange);
     HX_DELETE(m_pLogSink);
 


_______________________________________________
Clientapps-cvs mailing list
Clientapps-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/clientapps-cvs
[prev in list] [next in list] [prev in thread] [next in thread]