[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-client-cvs
Subject:    [Client-cvs] core hxconnbwinfo.cpp,1.20,1.21
From:       balcock () helixcommunity ! org
Date:       2011-08-01 15:53:26
Message-ID: 201108011553.p71FriOG026170 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/client/core
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv20561

Modified Files:
	hxconnbwinfo.cpp 
Log Message:
"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."  
Modified by: ext-debashis.2.panigrahi@nokia.com
 
Reviewed by: Girish Shetty (girish.shetty@nokia.com)
 
TSW Id: ou1cimx1#845703
 
Date: 06/24/2011
 
Project: SymbianMmf_wm
 
Synopsis:   can't start streaming - Unable to connect to server, not enough bandwidth
 
Overview:  Auto Bandwidth Detection (ABD) (that comes in OPTION response
header) is not supported by this server. As ABD is enabled in the system by default, \
so we go ahead and assign a default value (low-GPRS) to connection bandwidth. Which \
gets stored in the preferences and cause problem when we try to connect to the server \
even though the bearer supports higher bandwidths.  
Fix:  If ABD is not supported by the server then don't have to read the \
"ABDSystemEnabled" flag from the preference.This way we will set the connection \
bandwidth to max bandwidth supported for the network.  
Files modified & changes:
/cvsroot/client/core/hxconnbwinfo.cpp
/cvsroot/client/core/hxconnbwinfo.h
 
Image Size and Heap Use impact: No major impact
 
Module Release testing (STIF): Yes
 
Test case(s) Added: No 
 
Memory leak check performed: Passed, No additional leaks introduced.
 
Platforms and Profiles Build Verified: helix-client-symbian-4
 
Platforms and Profiles Functionality verified: armv5
 
Branch: 420Brizo and HEAD


Index: hxconnbwinfo.cpp
===================================================================
RCS file: /cvsroot/client/core/hxconnbwinfo.cpp,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -d -r1.20 -r1.21
--- hxconnbwinfo.cpp	3 Aug 2007 10:23:46 -0000	1.20
+++ hxconnbwinfo.cpp	1 Aug 2011 15:53:24 -0000	1.21
@@ -226,7 +226,8 @@
     m_uABDCalibrationBW(0),
     m_pMutex(NULL),
     m_sinkDispatchItr(0),
-    m_bGotDynamicABDSample(FALSE)
+    m_bGotDynamicABDSample(FALSE),
+	m_bABDNotSupported(FALSE)
 {
     HXLOGL3(HXLOG_CBWI, "%p CBI::CBI", this);
 }
@@ -847,7 +848,19 @@
 #ifdef HELIX_FEATURE_DISABLE_AUTOBWDETECTION
     bABDSystemEnabled = FALSE;
 #else
-    ReadPrefBOOL( m_pContext, "ABDSystemEnabled", bABDSystemEnabled);
+	//If ABD is not supported by the server then don't have to read
+	//the "ABDSystemEnabled" flag from the preference
+	if(m_bABDNotSupported)
+	{
+	bABDSystemEnabled = FALSE;
+	//Clear the flag as we have already used this flag for the
+	//current bandwidth computation
+	m_bABDNotSupported = FALSE;
+	}
+	else
+	{
+	ReadPrefBOOL( m_pContext, "ABDSystemEnabled", bABDSystemEnabled);
+	}
 #endif
         
 
@@ -1070,6 +1083,7 @@
 {
     // Remove the sink for this ABD object since ABD is not supported
     removeABDSink(pABD);
+	m_bABDNotSupported = TRUE;
     recalc();
 }
 


_______________________________________________
Client-cvs mailing list
Client-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/client-cvs


[prev in list] [next in list] [prev in thread] [next in thread]