[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-client-cvs
Subject:    [Client-cvs] core hxflsrc.cpp,1.144,1.145
From:       ching_li () helixcommunity ! org
Date:       2011-01-26 9:32:30
Message-ID: 201101260932.p0Q9WX86026253 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/client/core
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv4997

Modified Files:
	hxflsrc.cpp 
Log Message:
Fix a memory leak issue.


Index: hxflsrc.cpp
===================================================================
RCS file: /cvsroot/client/core/hxflsrc.cpp,v
retrieving revision 1.144
retrieving revision 1.145
diff -u -d -r1.144 -r1.145
--- hxflsrc.cpp	25 Jan 2011 08:43:27 -0000	1.144
+++ hxflsrc.cpp	26 Jan 2011 09:32:27 -0000	1.145
@@ -879,6 +879,8 @@
 	    HX_VECTOR_DELETE(m_pExtension);
 	    m_pExtension = ::new_string(pExtension);
 	}
+
+        // We can't delete pszURL now, because pExtension points to the sub-string in pszURL,
     }
 
     if (!m_pCurrentFileFormatUnk)
@@ -926,6 +928,9 @@
   	// without treating # as fragment delimiter    
 	if(m_bSeparateFragment && bIsFileURL && bIsFragmentFound)
 	{
+            // We can delete pszURL now.
+            HX_VECTOR_DELETE(pszURL);
+
 	    m_bSeparateFragment = FALSE;
 	    AttempToLoadFilePlugin(pMimeType);
 
@@ -980,6 +985,7 @@
 	theErr = InitializeFileFormat();
     }
 
+    // We can delete pszURL now.
     HX_VECTOR_DELETE(pszURL);
 
     // if there is an error, make sure there is no m_pCurrentFileFormatUnk...


_______________________________________________
Client-cvs mailing list
Client-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/client-cvs
[prev in list] [next in list] [prev in thread] [next in thread]