[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hail-devel
Subject:    [Patch 3/8] CLD: cleanup: if() to switch()
From:       Pete Zaitcev <zaitcev () redhat ! com>
Date:       2010-04-14 18:34:19
Message-ID: 20100414123419.258cb527 () redhat ! com
[Download RAW message or body]

I distinctly remember how my precious ifs were mercilessly replaced
elsewhere, but apparently this piece escaped notice thus far.
Now, make it more style-uniform with the rest.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>

---
 lib/cldc.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/cldc.c b/lib/cldc.c
index be8598f..305e05d 100644
--- a/lib/cldc.c
+++ b/lib/cldc.c
@@ -1386,10 +1388,12 @@ static void ncld_thread_command(struct ncld_sess *nsess)
 		abort();
 	}
 
-	if (cmd == NCLD_CMD_END) {
+	switch (cmd) {
+	case NCLD_CMD_END:
 		/* No answer to requestor. Wait with g_thread_join. */
 		g_thread_exit(NULL);
-	} else if (cmd == NCLD_CMD_SESEV) {
+		break;
+	case NCLD_CMD_SESEV:
 		rrc = read(nsess->to_thread[0], &what, sizeof(uint32_t));
 		if (rrc < sizeof(uint32_t)) {
 			fprintf(stderr, "bad read param\n");
@@ -1397,7 +1401,8 @@ static void ncld_thread_command(struct ncld_sess *nsess)
 		}
 		if (nsess->event)
 			nsess->event(nsess->event_arg, what);
-	} else {
+		break;
+	default:
 		fprintf(stderr, "bad command 0x%x\n", cmd);
 		abort();
 	}
--
To unsubscribe from this list: send the line "unsubscribe hail-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]