[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-development
Subject:    [haiku-development] Re: [Important] movingborders.es, rogue Gerrit build checking bot
From:       "Adrien Destugues" <pulkomandy () pulkomandy ! tk>
Date:       2021-05-24 10:34:18
Message-ID: 1ce09f3fd05c0dfbdfd2c72add762b20 () pulkomandy ! tk
[Download RAW message or body]

>> We accepted several GSOC students, and one of the projects
>> was accomplishing this very task...

>> The original plan for the GSOC project was to integrate our Gerrit
>> build tester within our concourse install. (so it would leverage all
>> of our normal pipelines and builders)
> 
> I thought that was left for another run, with current ones "just" integrating the style checker.
> Once that is done, the build check should be very easy, though.
> 
> To be clear, I think integrating the checkers in Haiku's infrastructure is the way to go and GSOC
> students (or anyone else) can and should work on it. I see my builds as a temporary thing and a
> quite dirty subproduct of something else I was playing with. They should disappear once The Right
> Thing is working.

To further clarify what I have in mind for the different GSoC projects in this area:

Saloni is working on improving clang-format and possibly clang-tidy to be allow to use them with
our coding guidelines. Currently the tools are not flexible enough for this.

Hrithik is working on integrating these tools in the existing infrastructure (Concourse and Gerrit).
It seems a good idea to start with something similar to what madmax did: a simple "verified" label.
But it could go a lot further, for example collecting compiler errors and putting inline comments
on the corresponding sourcecode lines in the Gerrit review to make it easier to find the problems.
Similarly for code formatting, it could put comments on the lines that are not properly formatted.

The work done with the movingborders bot allowed us to experiment with the Gerrit configuration and
get a first version of some things up and running. But we should eventually put this back into the
hands of the sysadmin team, and in that context it makes sense to move most of this into Concourse.

-- 
Adrien.


[prev in list] [next in list] [prev in thread] [next in thread]