[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-development
Subject:    [haiku-development] Re: Checker bot for Gerrit
From:       saloni goyal <salonig1212 () gmail ! com>
Date:       2021-05-01 20:13:57
Message-ID: CALYoBSRS+MNU2i1e5yTEguUwjRXmuaVPyqEgNzbG8eNkEGfi5g () mail ! gmail ! com
[Download RAW message or body]

On Sun, May 2, 2021 at 12:23 AM Adrien Destugues
<pulkomandy@pulkomandy.tk> wrote:
>
> > Here is the link for the changes made by me:
> > https://github.com/saloniig/llvm-project/commit/d09b1459b76a71508cc814b742b952cf61310d92
> >
> > Please suggest the required changes to get the expected outcome.
>
> Thanks, much easier to look at this with the code :)
>
> I have written some comments and suggestions in the commit on github.

Thank you so much for your suggestions. It helped me a lot :)

> The comments in the code say that it's crashing, is that still correct? From your email
> I thought it was not crashing, but not formatting correctly.

The application only crashes when I try to use the indent value of
previousNonComment in the code.

Thanks
Saloni

[prev in list] [next in list] [prev in thread] [next in thread]