[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    [haiku-commits] haiku: hrev57718 - src/kits/interface
From:       waddlesplash <waddlesplash () gmail ! com>
Date:       2024-04-30 19:12:38
Message-ID: 20240430191238.D06D64B75B () turing ! freelists ! org
[Download RAW message or body]

hrev57718 adds 1 changeset to branch 'master'
old head: 9f3bdf3d039430b5172c424def20ce5d9f7367d4
new head: 0464fca49a7a811c0352ecff49ebe918660221f9
overview: https://git.haiku-os.org/haiku/log/?qt=range&q=0464fca49a7a+%5E9f3bdf3d0394

----------------------------------------------------------------------------

0464fca49a7a: BSpinner: restore local copy of control value
  
  8cc8ec9ef9db55e0f730d6fe85b9af58aedf593c fixed a problem due to BSpinner
  using its own variable to store the value instead of resorting to
  BControl's one. That was accessed with a inline method, so programs
  compiled before the change get the spinner's value from a place that in
  newer revisions contain garbage. Copy the value to that position after
  changes, so that it is available for both old and new apps.
  
  Fixes: #18898
  Change-Id: I01679bfcb5b208e04ea85d7ec38cc655305d532a
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/7657
  Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
  Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>

                                    [ Máximo Castañeda <antiswen@yahoo.es> ]

----------------------------------------------------------------------------

Revision:    hrev57718
Commit:      0464fca49a7a811c0352ecff49ebe918660221f9
URL:         https://git.haiku-os.org/haiku/commit/?id=0464fca49a7a
Author:      Máximo Castañeda <antiswen@yahoo.es>
Date:        Tue Apr 30 18:35:44 2024 UTC
Committer:   waddlesplash <waddlesplash@gmail.com>
Commit-Date: Tue Apr 30 19:12:36 2024 UTC

Ticket:      https://dev.haiku-os.org/ticket/18898

----------------------------------------------------------------------------

1 file changed, 2 insertions(+)
src/kits/interface/Spinner.cpp | 2 ++

----------------------------------------------------------------------------

diff --git a/src/kits/interface/Spinner.cpp b/src/kits/interface/Spinner.cpp
index d97ba094d4..a9eafbcb73 100644
--- a/src/kits/interface/Spinner.cpp
+++ b/src/kits/interface/Spinner.cpp
@@ -241,6 +241,8 @@ BSpinner::SetValue(int32 value)
 		return;
 
 	BControl::SetValue(value);
+	((int32*)_reserved)[0] = Value();
+
 	ValueChanged();
 
 	Invoke();


[prev in list] [next in list] [prev in thread] [next in thread]