[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    [haiku-commits] [S] Change in haiku[master]: Tracker: Fix memory leak
From:       Gerrit <review () review ! haiku-os ! org>
Date:       2023-05-31 14:38:19
Message-ID: b524f86ee04e9791ec475e1d8705724ca3d47042-HTML () review ! haiku-os ! org
[Download RAW message or body]

From <0azrune6@zard.anonaddy.com>:

0azrune6@zard.anonaddy.com has uploaded this change for review. ( \
https://review.haiku-os.org/c/haiku/+/6485 )


Change subject: Tracker: Fix memory leak
......................................................................

Tracker: Fix memory leak

Change-Id: I2fa8e9e87d1097cfc358cc3653240aeac6efb910
---
M src/kits/tracker/ContainerWindow.cpp
1 file changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/85/6485/1

diff --git a/src/kits/tracker/ContainerWindow.cpp \
b/src/kits/tracker/ContainerWindow.cpp index fc5e082..d31b480 100644
--- a/src/kits/tracker/ContainerWindow.cpp
+++ b/src/kits/tracker/ContainerWindow.cpp
@@ -780,6 +780,9 @@
 	delete fDragContextMenu;
 	fDragContextMenu = NULL;

+	delete fTrashContextMenu;
+	fTrashContextMenu = NULL;
+
 	int32 windowCount = 0;

 	// This is a deadlock code sequence - need to change this

--
To view, visit https://review.haiku-os.org/c/haiku/+/6485
To unsubscribe, or for help writing mail filters, visit \
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: I2fa8e9e87d1097cfc358cc3653240aeac6efb910
Gerrit-Change-Number: 6485
Gerrit-PatchSet: 1
Gerrit-Owner: 0azrune6@zard.anonaddy.com
Gerrit-MessageType: newchange


[Attachment #3 (text/html)]

<p>0azrune6@zard.anonaddy.com has uploaded this change for \
<strong>review</strong>.</p><p><a \
href="https://review.haiku-os.org/c/haiku/+/6485">View Change</a></p><pre \
style="font-family: monospace,monospace; white-space: pre-wrap;">Tracker: Fix memory \
leak<br><br>Change-Id: I2fa8e9e87d1097cfc358cc3653240aeac6efb910<br>---<br>M \
src/kits/tracker/ContainerWindow.cpp<br>1 file changed, 12 insertions(+), 0 \
deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: \
pre-wrap;">git pull ssh://git.haiku-os.org:22/haiku refs/changes/85/6485/1</pre><pre \
style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git \
a/src/kits/tracker/ContainerWindow.cpp \
b/src/kits/tracker/ContainerWindow.cpp</span><br><span>index fc5e082..d31b480 \
100644</span><br><span>--- a/src/kits/tracker/ContainerWindow.cpp</span><br><span>+++ \
b/src/kits/tracker/ContainerWindow.cpp</span><br><span>@@ -780,6 +780,9 \
@@</span><br><span> 	delete fDragContextMenu;</span><br><span> 	fDragContextMenu = \
NULL;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+	delete \
fTrashContextMenu;</span><br><span style="color: hsl(120, 100%, \
40%);">+	fTrashContextMenu = NULL;</span><br><span style="color: hsl(120, 100%, \
40%);">+</span><br><span> 	int32 windowCount = 0;</span><br><span> </span><br><span> \
// This is a deadlock code sequence - need to change \
this</span><br><span></span><br></pre><p>To view, visit <a \
href="https://review.haiku-os.org/c/haiku/+/6485">change 6485</a>. To unsubscribe, or \
for help writing mail filters, visit <a \
href="https://review.haiku-os.org/settings">settings</a>.</p><div itemscope \
itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" \
itemtype="http://schema.org/ViewAction"><link itemprop="url" \
href="https://review.haiku-os.org/c/haiku/+/6485"/><meta itemprop="name" \
content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: haiku </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: \
I2fa8e9e87d1097cfc358cc3653240aeac6efb910 </div> <div style="display:none"> \
Gerrit-Change-Number: 6485 </div> <div style="display:none"> Gerrit-PatchSet: 1 \
</div> <div style="display:none"> Gerrit-Owner: 0azrune6@zard.anonaddy.com </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>



[prev in list] [next in list] [prev in thread] [next in thread]