[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    [haiku-commits] Change in haiku[master]: boot/efi/dtb: require exact match for PL011 in device tree
From:       Gerrit <review () review ! haiku-os ! org>
Date:       2021-11-24 17:23:23
Message-ID: gerrit.1637774599000.Ida6450e9e71dac834770d558e4ab95c5574970cb () review ! haiku-os ! org
[Download RAW message or body]

From <karolyd577@gmail=2Ecom>:

karolyd577@gmail=2Ecom has uploaded this ch=
ange for review=2E ( https://review=2Ehaiku-os=2Eorg/c/haiku/+/4733 )


Cha=
nge subject: boot/efi/dtb: require exact match for PL011 in device tree
=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E

boot/efi/dtb: re=
quire exact match for PL011 in device tree

Don't match PL011 for arm,prime=
cell compatibility string
as it can indicate other peripherals=2E

Primecel=
l peripherals have the generic "arm,primcecell"
name as well as a specific =
name in the format of "arm,pl???"

see:
https://www=2Ekernel=2Eorg/doc/Docu=
mentation/devicetree/bindings/arm/primecell=2Etxt

Change-Id: Ida6450e9e71d=
ac834770d558e4ab95c5574970cb
---
M src/system/boot/platform/efi/dtb=2Ecpp
1=
 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://git=2Ehai=
ku-os=2Eorg:22/haiku refs/changes/33/4733/1

diff --git a/src/system/boot/p=
latform/efi/dtb=2Ecpp b/src/system/boot/platform/efi/dtb=2Ecpp
index 88241e=
8=2E=2E1be71c8 100644
--- a/src/system/boot/platform/efi/dtb=2Ecpp
+++ b/sr=
c/system/boot/platform/efi/dtb=2Ecpp
@@ -69,7 +69,6 @@
 	{ "sifive,uart0", =
UART_KIND_SIFIVE, &get_uart<ArchUARTSifive> },
 #elif defined(__ARM__) || d=
efined(__aarch64__)
 	{ "arm,pl011", UART_KIND_PL011, &get_uart<ArchUARTPL0=
11> },
-	{ "arm,primecell", UART_KIND_PL011, &get_uart<ArchUARTPL011> },
 #=
endif
 };
 

-- 
To view, visit https://review=2Ehaiku-os=2Eorg/c/haiku/+/4=
733
To unsubscribe, or for help writing mail filters, visit https://review=
=2Ehaiku-os=2Eorg/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Ger=
rit-Change-Id: Ida6450e9e71dac834770d558e4ab95c5574970cb
Gerrit-Change-Numb=
er: 4733
Gerrit-PatchSet: 1
Gerrit-Owner: karolyd577@gmail=2Ecom
Gerrit-Mes=
sageType: newchange

[Attachment #3 (text/html)]

<p>karolyd577@gmail.com has uploaded this change for \
<strong>review</strong>.</p><p><a \
href="https://review.haiku-os.org/c/haiku/+/4733">View Change</a></p><pre \
style="font-family: monospace,monospace; white-space: pre-wrap;">boot/efi/dtb: \
require exact match for PL011 in device tree<br><br>Don&#39;t match PL011 for \
arm,primecell compatibility string<br>as it can indicate other \
peripherals.<br><br>Primecell peripherals have the generic \
&quot;arm,primcecell&quot;<br>name as well as a specific name in the format of \
&quot;arm,pl???&quot;<br><br>see:<br>https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/primecell.txt<br><br>Change-Id: \
Ida6450e9e71dac834770d558e4ab95c5574970cb<br>---<br>M \
src/system/boot/platform/efi/dtb.cpp<br>1 file changed, 0 insertions(+), 1 \
deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: \
pre-wrap;">git pull ssh://git.haiku-os.org:22/haiku refs/changes/33/4733/1</pre><pre \
style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git \
a/src/system/boot/platform/efi/dtb.cpp \
b/src/system/boot/platform/efi/dtb.cpp</span><br><span>index 88241e8..1be71c8 \
100644</span><br><span>--- a/src/system/boot/platform/efi/dtb.cpp</span><br><span>+++ \
b/src/system/boot/platform/efi/dtb.cpp</span><br><span>@@ -69,7 +69,6 \
@@</span><br><span> 	{ &quot;sifive,uart0&quot;, UART_KIND_SIFIVE, \
&amp;get_uart&lt;ArchUARTSifive&gt; },</span><br><span> #elif defined(__ARM__) || \
defined(__aarch64__)</span><br><span> 	{ &quot;arm,pl011&quot;, UART_KIND_PL011, \
&amp;get_uart&lt;ArchUARTPL011&gt; },</span><br><span style="color: hsl(0, 100%, \
40%);">-	{ &quot;arm,primecell&quot;, UART_KIND_PL011, \
&amp;get_uart&lt;ArchUARTPL011&gt; },</span><br><span> #endif</span><br><span> \
};</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a \
href="https://review.haiku-os.org/c/haiku/+/4733">change 4733</a>. To unsubscribe, or \
for help writing mail filters, visit <a \
href="https://review.haiku-os.org/settings">settings</a>.</p><div itemscope \
itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" \
itemtype="http://schema.org/ViewAction"><link itemprop="url" \
href="https://review.haiku-os.org/c/haiku/+/4733"/><meta itemprop="name" \
content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: haiku </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: \
Ida6450e9e71dac834770d558e4ab95c5574970cb </div> <div style="display:none"> \
Gerrit-Change-Number: 4733 </div> <div style="display:none"> Gerrit-PatchSet: 1 \
</div> <div style="display:none"> Gerrit-Owner: karolyd577@gmail.com </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>



[prev in list] [next in list] [prev in thread] [next in thread]