[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    [haiku-commits] haiku: hrev54605 - src/add-ons/kernel/busses/usb
From:       Adrien Destugues <pulkomandy () gmail ! com>
Date:       2020-09-27 14:19:53
Message-ID: 20200927141953.5AFC124DC6 () turing ! freelists ! org
[Download RAW message or body]

hrev54605 adds 1 changeset to branch 'master'
old head: f30ba67705f84b0c72ec2c2d276b4528d610f888
new head: 68a0df3e0e085a36fc0b1a15a767ce2e9b2c2666
overview: https://git.haiku-os.org/haiku/log/?qt=range&q=68a0df3e0e08+%5Ef30ba67705f8

----------------------------------------------------------------------------

68a0df3e0e08: usb/uhci: Remove unneeded NULL check
  
  Thanks to mmlr for pointing out element could not be NULL.
  
  Change-Id: I89d85fdd2cc30efd54c81f6c50a5497208bab5d2
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/3259
  Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>

                                      [ Murai Takashi <tmurai01@gmail.com> ]

----------------------------------------------------------------------------

Revision:    hrev54605
Commit:      68a0df3e0e085a36fc0b1a15a767ce2e9b2c2666
URL:         https://git.haiku-os.org/haiku/commit/?id=68a0df3e0e08
Author:      Murai Takashi <tmurai01@gmail.com>
Date:        Sat Aug  1 21:20:06 2020 UTC
Committer:   Adrien Destugues <pulkomandy@gmail.com>
Commit-Date: Sun Sep 27 14:19:50 2020 UTC

----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 1 deletion(-)
src/add-ons/kernel/busses/usb/uhci.cpp | 2 +-

----------------------------------------------------------------------------

diff --git a/src/add-ons/kernel/busses/usb/uhci.cpp b/src/add-ons/kernel/busses/usb/uhci.cpp
index 798dd60d81..9fcd787ed5 100644
--- a/src/add-ons/kernel/busses/usb/uhci.cpp
+++ b/src/add-ons/kernel/busses/usb/uhci.cpp
@@ -215,7 +215,7 @@ Queue::AppendTransfer(uhci_qh *transfer, bool lock)
 	} else {
 		// append the transfer queue to the list
 		uhci_qh *element = fQueueTop;
-		while (element && element->link_log)
+		while (element->link_log != NULL)
 			element = (uhci_qh *)element->link_log;
 
 		element->link_log = transfer;


[prev in list] [next in list] [prev in thread] [next in thread]