[prev in list] [next in list] [prev in thread] [next in thread]
List: haiku-commits
Subject: [haiku-commits] Change in haiku[master]: hda: enable pci snooping on AMD non-hdmi.
From: Gerrit <review () review ! haiku-os ! org>
Date: 2020-02-27 20:43:12
Message-ID: gerrit.1582836189000.Ic62e8c7ae376a1e26646f88f308242eef3aa119e () review ! haiku-os ! org
[Download RAW message or body]
From Jérôme Duval <jerome.duval@gmail.com>:
Jérôme Duval has uploaded this change for review. ( \
https://review.haiku-os.org/c/haiku/+/2287 )
Change subject: hda: enable pci snooping on AMD non-hdmi.
......................................................................
hda: enable pci snooping on AMD non-hdmi.
disable snooping on ATI non-hdmi.
---
M src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp
1 file changed, 11 insertions(+), 3 deletions(-)
git pull ssh://git.haiku-os.org:22/haiku refs/changes/87/2287/1
diff --git a/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp \
b/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp index 5bc08d9..774a16d \
100644
--- a/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp
+++ b/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp
@@ -34,7 +34,8 @@
#define ALIGN(size, align) (((size) + align - 1) & ~(align - 1))
-#define PCI_VENDOR_AMD 0x1002
+#define PCI_VENDOR_ATI 0x1002
+#define PCI_VENDOR_AMD 0x1022
#define PCI_VENDOR_CREATIVE 0x1102
#define PCI_VENDOR_INTEL 0x8086
#define PCI_VENDOR_NVIDIA 0x10de
@@ -81,9 +82,15 @@
{ PCI_VENDOR_INTEL, 0xa171, HDA_QUIRK_SNOOP },
{ PCI_VENDOR_INTEL, 0xa2f0, HDA_QUIRK_SNOOP },
{ PCI_VENDOR_INTEL, 0xa348, HDA_QUIRK_SNOOP },
- // Enable snooping for ATI and Nvidia, right now for all their hda-devices,
+ { PCI_VENDOR_ATI, 0x437b, HDA_QUIRK_SNOOP },
+ { PCI_VENDOR_ATI, 0x4383, HDA_QUIRK_SNOOP },
+ { PCI_VENDOR_AMD, 0x157a, HDA_QUIRK_SNOOP },
+ { PCI_VENDOR_AMD, 0x780d, HDA_QUIRK_SNOOP },
+ { PCI_VENDOR_AMD, 0x1457, HDA_QUIRK_SNOOP },
+ { PCI_VENDOR_AMD, 0x1487, HDA_QUIRK_SNOOP },
+ { PCI_VENDOR_AMD, 0x15e3, HDA_QUIRK_SNOOP },
+ // Enable snooping for Nvidia, right now for all their hda-devices,
// but only based on guessing.
- { PCI_VENDOR_AMD, PCI_ALL_DEVICES, HDA_QUIRK_SNOOP },
{ PCI_VENDOR_NVIDIA, PCI_ALL_DEVICES, HDA_QUIRK_SNOOP | HDA_QUIRK_NO_MSI
| HDA_QUIRK_NO_CORBRP_RESET_ACK },
{ PCI_VENDOR_CREATIVE, 0x0010, HDA_QUIRK_NO_MSI },
@@ -1071,6 +1078,7 @@
}
case PCI_VENDOR_AMD:
+ case PCI_VENDOR_ATI:
{
controller->dma_snooping = update_pci_register(controller,
ATI_HDA_MISC_CNTR2, ATI_HDA_MISC_CNTR2_MASK,
--
To view, visit https://review.haiku-os.org/c/haiku/+/2287
To unsubscribe, or for help writing mail filters, visit \
https://review.haiku-os.org/settings
Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Ic62e8c7ae376a1e26646f88f308242eef3aa119e
Gerrit-Change-Number: 2287
Gerrit-PatchSet: 1
Gerrit-Owner: Jérôme Duval <jerome.duval@gmail.com>
Gerrit-MessageType: newchange
[Attachment #3 (text/html)]
<p>Jérôme Duval has uploaded this change for <strong>review</strong>.</p><p><a \
href="https://review.haiku-os.org/c/haiku/+/2287">View Change</a></p><pre \
style="font-family: monospace,monospace; white-space: pre-wrap;">hda: enable pci \
snooping on AMD non-hdmi.<br><br>disable snooping on ATI non-hdmi.<br>---<br>M \
src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp<br>1 file changed, 11 \
insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: \
monospace,monospace; white-space: pre-wrap;">git pull ssh://git.haiku-os.org:22/haiku \
refs/changes/87/2287/1</pre><pre style="font-family: monospace,monospace; \
white-space: pre-wrap;"><span>diff --git \
a/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp \
b/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp</span><br><span>index \
5bc08d9..774a16d 100644</span><br><span>--- \
a/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp</span><br><span>+++ \
b/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp</span><br><span>@@ -34,7 \
+34,8 @@</span><br><span> #define ALIGN(size, align) (((size) + align - 1) & \
~(align - 1))</span><br><span> </span><br><span> </span><br><span style="color: \
hsl(0, 100%, 40%);">-#define PCI_VENDOR_AMD 0x1002</span><br><span style="color: \
hsl(120, 100%, 40%);">+#define PCI_VENDOR_ATI 0x1002</span><br><span style="color: \
hsl(120, 100%, 40%);">+#define PCI_VENDOR_AMD 0x1022</span><br><span> #define \
PCI_VENDOR_CREATIVE 0x1102</span><br><span> #define \
PCI_VENDOR_INTEL 0x8086</span><br><span> #define \
PCI_VENDOR_NVIDIA 0x10de</span><br><span>@@ -81,9 +82,15 @@</span><br><span> { \
PCI_VENDOR_INTEL, 0xa171, HDA_QUIRK_SNOOP },</span><br><span> { PCI_VENDOR_INTEL, \
0xa2f0, HDA_QUIRK_SNOOP },</span><br><span> { PCI_VENDOR_INTEL, 0xa348, \
HDA_QUIRK_SNOOP },</span><br><span style="color: hsl(0, 100%, 40%);">- // Enable \
snooping for ATI and Nvidia, right now for all their hda-devices,</span><br><span \
style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ATI, 0x437b, HDA_QUIRK_SNOOP \
},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ATI, 0x4383, \
HDA_QUIRK_SNOOP },</span><br><span style="color: hsl(120, 100%, 40%);">+ { \
PCI_VENDOR_AMD, 0x157a, HDA_QUIRK_SNOOP },</span><br><span style="color: hsl(120, \
100%, 40%);">+ { PCI_VENDOR_AMD, 0x780d, HDA_QUIRK_SNOOP },</span><br><span \
style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_AMD, 0x1457, HDA_QUIRK_SNOOP \
},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_AMD, 0x1487, \
HDA_QUIRK_SNOOP },</span><br><span style="color: hsl(120, 100%, 40%);">+ { \
PCI_VENDOR_AMD, 0x15e3, HDA_QUIRK_SNOOP },</span><br><span style="color: hsl(120, \
100%, 40%);">+ // Enable snooping for Nvidia, right now for all their \
hda-devices,</span><br><span> // but only based on guessing.</span><br><span \
style="color: hsl(0, 100%, 40%);">- { PCI_VENDOR_AMD, PCI_ALL_DEVICES, \
HDA_QUIRK_SNOOP },</span><br><span> { PCI_VENDOR_NVIDIA, PCI_ALL_DEVICES, \
HDA_QUIRK_SNOOP | HDA_QUIRK_NO_MSI</span><br><span> | HDA_QUIRK_NO_CORBRP_RESET_ACK \
},</span><br><span> { PCI_VENDOR_CREATIVE, 0x0010, HDA_QUIRK_NO_MSI \
},</span><br><span>@@ -1071,6 +1078,7 @@</span><br><span> }</span><br><span> \
</span><br><span> case PCI_VENDOR_AMD:</span><br><span style="color: hsl(120, \
100%, 40%);">+ case PCI_VENDOR_ATI:</span><br><span> {</span><br><span> \
controller->dma_snooping = update_pci_register(controller,</span><br><span> \
ATI_HDA_MISC_CNTR2, ATI_HDA_MISC_CNTR2_MASK,</span><br><span></span><br></pre><p>To \
view, visit <a href="https://review.haiku-os.org/c/haiku/+/2287">change 2287</a>. To \
unsubscribe, or for help writing mail filters, visit <a \
href="https://review.haiku-os.org/settings">settings</a>.</p><div itemscope \
itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" \
itemtype="http://schema.org/ViewAction"><link itemprop="url" \
href="https://review.haiku-os.org/c/haiku/+/2287"/><meta itemprop="name" \
content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: haiku </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: \
Ic62e8c7ae376a1e26646f88f308242eef3aa119e </div> <div style="display:none"> \
Gerrit-Change-Number: 2287 </div> <div style="display:none"> Gerrit-PatchSet: 1 \
</div> <div style="display:none"> Gerrit-Owner: Jérôme Duval \
<jerome.duval@gmail.com> </div> <div style="display:none"> Gerrit-MessageType: \
newchange </div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic