[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    [haiku-commits] haiku: hrev53917 - src/kits/tracker
From:       waddlesplash <waddlesplash () gmail ! com>
Date:       2020-02-25 5:06:18
Message-ID: 20200225050618.09BE522DEF () turing ! freelists ! org
[Download RAW message or body]

hrev53917 adds 1 changeset to branch 'master'
old head: 48de299d5436f3989377719ed6dbeaf167935fa5
new head: 3548a2eb718fb9d32057960aa0fd50cd2988b0f3
overview: https://git.haiku-os.org/haiku/log/?qt=range&q=3548a2eb718f+%5E48de299d5436

----------------------------------------------------------------------------

3548a2eb718f: tracker: Fix PVS V595
  
  Fix 'fFile' pointer was utilized at line 327
  before it was verified against NULL.
  
  Change-Id: I8214bce9a99d783b3c53a7b8c5696b0b0dfc3490
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/1440
  Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
  Reviewed-by: waddlesplash <waddlesplash@gmail.com>

                                      [ Murai Takashi <tmurai01@gmail.com> ]

----------------------------------------------------------------------------

Revision:    hrev53917
Commit:      3548a2eb718fb9d32057960aa0fd50cd2988b0f3
URL:         https://git.haiku-os.org/haiku/commit/?id=3548a2eb718f
Author:      Murai Takashi <tmurai01@gmail.com>
Date:        Thu Mar 14 11:33:03 2019 UTC
Committer:   waddlesplash <waddlesplash@gmail.com>
Commit-Date: Tue Feb 25 05:06:14 2020 UTC

----------------------------------------------------------------------------

1 file changed, 2 insertions(+), 2 deletions(-)
src/kits/tracker/FindPanel.cpp | 4 ++--

----------------------------------------------------------------------------

diff --git a/src/kits/tracker/FindPanel.cpp b/src/kits/tracker/FindPanel.cpp
index 3365ce6284..0b62c9e715 100644
--- a/src/kits/tracker/FindPanel.cpp
+++ b/src/kits/tracker/FindPanel.cpp
@@ -323,14 +323,14 @@ const char*
 FindWindow::QueryName() const
 {
 	if (fFromTemplate) {
-		if (!fQueryNameFromTemplate.Length()) {
+		if (!fQueryNameFromTemplate.Length() && fFile != NULL) {
 			fFile->ReadAttrString(kAttrQueryTemplateName,
 				&fQueryNameFromTemplate);
 		}
 
 		return fQueryNameFromTemplate.String();
 	}
-	if (!fFile)
+	if (fFile == NULL)
 		return "";
 
 	return fRef.name;


[prev in list] [next in list] [prev in thread] [next in thread]