[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    [haiku-commits] Re: haiku: hrev53424 - in src/tests: add-ons/kernel/partitioning_systems system/kern
From:       Jérôme Duval <jerome.duval () gmail ! com>
Date:       2019-08-30 15:34:33
Message-ID: CAPZRpdPsnOZeFH0nstsMx1O0Pp-_Vxf-1JWpEDfSwV0tdvY7Yw () mail ! gmail ! com
[Download RAW message or body]

Le ven. 30 ao=C3=BBt 2019 =C3=A0 16:25, waddlesplash <waddlesplash@gmail.co=
m> a
=C3=A9crit :

> diff --git
> a/src/tests/system/kernel/device_manager/playground/specific_video_driver=
.cpp
> b/src/tests/system/kernel/device_manager/playground/specific_video_driver=
.cpp
> index 198e7994ca..5d445ac1ff 100644
> ---
> a/src/tests/system/kernel/device_manager/playground/specific_video_driver=
.cpp
> +++
> b/src/tests/system/kernel/device_manager/playground/specific_video_driver=
.cpp
> @@ -8,6 +8,7 @@
>
>  #include <KernelExport.h>
>  #include <PCI.h>
> +#include <string.h>
>
>
> diff --git
> a/src/tests/add-ons/kernel/partitioning_systems/PartitioningSystemsTest.c=
pp
> b/src/tests/add-ons/kernel/partitioning_systems/PartitioningSystemsTest.c=
pp
> index c3168931eb..cca906eaa7 100644
> ---
> a/src/tests/add-ons/kernel/partitioning_systems/PartitioningSystemsTest.c=
pp
> +++
> b/src/tests/add-ons/kernel/partitioning_systems/PartitioningSystemsTest.c=
pp
> @@ -9,6 +9,8 @@
>  #include <limits.h>
>  #include <stdio.h>
>  #include <unistd.h>
> +#include <string.h>
> +#include <stdlib.h>
>
>  #include <map>
>  #include <vector>
>
>
>
In both commits, the include macro is wrongly ordered, please adjust
following the coding style guide.

Bye,
J=C3=A9r=C3=B4me

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">Le  ven. 30 août 2019 à  16:25, waddlesplash &lt;<a \
href="mailto:waddlesplash@gmail.com">waddlesplash@gmail.com</a>&gt; a écrit  \
:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">diff --git \
a/src/tests/system/kernel/device_manager/playground/specific_video_driver.cpp \
b/src/tests/system/kernel/device_manager/playground/specific_video_driver.cpp<br> \
                index 198e7994ca..5d445ac1ff 100644<br>
--- a/src/tests/system/kernel/device_manager/playground/specific_video_driver.cpp<br>
+++ b/src/tests/system/kernel/device_manager/playground/specific_video_driver.cpp<br>
@@ -8,6 +8,7 @@<br>
<br>
  #include &lt;KernelExport.h&gt;<br>
  #include &lt;PCI.h&gt;<br>
+#include &lt;string.h&gt;<br>
<br>
<br>diff --git a/src/tests/add-ons/kernel/partitioning_systems/PartitioningSystemsTest.cpp \
b/src/tests/add-ons/kernel/partitioning_systems/PartitioningSystemsTest.cpp<br> index \
                c3168931eb..cca906eaa7 100644<br>
--- a/src/tests/add-ons/kernel/partitioning_systems/PartitioningSystemsTest.cpp<br>
+++ b/src/tests/add-ons/kernel/partitioning_systems/PartitioningSystemsTest.cpp<br>
@@ -9,6 +9,8 @@<br>
  #include &lt;limits.h&gt;<br>
  #include &lt;stdio.h&gt;<br>
  #include &lt;unistd.h&gt;<br>
+#include &lt;string.h&gt;<br>
+#include &lt;stdlib.h&gt;<br>
<br>
  #include &lt;map&gt;<br>
  #include &lt;vector&gt;<br>
<br>
<br></blockquote><div><br></div><div>In both commits, the include macro is wrongly \
ordered, please adjust following the coding style \
guide.</div><div><br></div><div>Bye,</div><div>Jérôme  </div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]