[prev in list] [next in list] [prev in thread] [next in thread]
List: haiku-commits
Subject: [haiku-commits] Re: haiku: hrev46445 - src/kits/network/libnetapi
From: Jérôme Duval <korli () users ! berlios ! de>
Date: 2013-11-26 22:40:27
Message-ID: CAPZRpdOR6u18Cw6LwdP=2uYjHG7+tBPinuAe2f4XXknxBQ+pig () mail ! gmail ! com
[Download RAW message or body]
2013/11/25 Axel Dörfler <axeld@pinc-software.de>:
> Am 25/11/2013 18:42, schrieb korli@users.berlios.de:
>>
>> - if (transparent)
>> - fSynchronousListener
>> +
>> + if (transparent)
>> + fSynchronousListener
>> = new(std::nothrow)
>> BUrlProtocolDispatchingListener(this);
>
>
> Looks like you missed a few: this is a multiline statement, and therefore
> deserves {}.
>
>> BUrlRequest* caller;
>> if (message->FindPointer(kUrlProtocolCaller,
>> reinterpret_cast<void**>(&caller)) != B_OK)
>> return;
>
>
> Is that cast really needed? And if it is, the second if-line should be
> indented one tab further than the next line.
>
>> int8 notification;
>> - if (message->FindInt8(kUrlProtocolMessageType, ¬ification)
>> + if (message->FindInt8(kUrlProtocolMessageType, ¬ification)
>> != B_OK)
>> return;
>
>
> Same indenting issue here.
>
>> case B_URL_PROTOCOL_HOSTNAME_RESOLVED:
>> {
>> const char* ip;
>> message->FindString("url:ip", &ip);
>> -
>> +
>> HostnameResolved(caller, ip);
>> }
>> break;
>
>
> The {} are not to be indented.
>
I hopefully fixed these violations, except for the last one which I forgot.
Bye,
Jérôme
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic