[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    [haiku-commits] Re: haiku: hrev46448 - src/kits/network/libnetapi headers/os/net
From:       Ingo Weinhold <ingo_weinhold () gmx ! de>
Date:       2013-11-26 12:11:00
Message-ID: 52948FD4.8020404 () gmx ! de
[Download RAW message or body]

On 11/26/2013 10:25 AM, pulkomandy@pulkomandy.tk wrote:
> diff --git a/headers/os/net/HttpRequest.h b/headers/os/net/HttpRequest.h
> index 9ca604c..4573552 100644
> --- a/headers/os/net/HttpRequest.h
> +++ b/headers/os/net/HttpRequest.h
> @@ -87,7 +85,6 @@ private:
>   			BString				fRequestMethod;
>   			int8				fHttpVersion;
>
> -			BString				fOutputBuffer;
>   			BNetBuffer			fInputBuffer;
>
>   			BHttpHeaders		fHeaders;

The current haikuwebkit packages already use these classes instead of 
curl, right? In that case care should be taken not to break binary 
compatibility without updating the packages as well. In this case the 
removed attribute could be replaced by a "void* fReserved", but with the 
next breakage that cannot be avoided I'd recommend introducing FBC 
insurance as well. Cleanups can then be postponed to convenient times 
(e.g. when a haikuwebkit package rebuild is necessary anyway) or right 
before declaring the API public.

CU, Ingo


[prev in list] [next in list] [prev in thread] [next in thread]