[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    [haiku-commits] haiku: hrev43916 - src/servers/app/drawing/remote
From:       revol () free ! fr
Date:       2012-03-31 14:13:55
Message-ID: 20120331141355.27F3E5C074C () vmrepo ! haiku-os ! org
[Download RAW message or body]

hrev43916 adds 2 changesets to branch 'master'
old head: 624b5ef3e6476077be291f58effd76121f19b49e
new head: 28b813df23ce0d5873dcf07a615685dfeae6b8ca

----------------------------------------------------------------------------

6371cd4: Fix uninitialized warning.

28b813d: Move callbackFunction type declaration into the class to avoid a name clash \
with future code.

                                          [ François Revol <revol@free.fr> ]

----------------------------------------------------------------------------

3 files changed, 4 insertions(+), 4 deletions(-)
.../app/drawing/remote/RemoteHWInterface.cpp       |    2 +-
src/servers/app/drawing/remote/RemoteHWInterface.h |    4 ++--
src/servers/app/drawing/remote/RemoteMessage.h     |    2 +-

############################################################################

Commit:      6371cd4deaff10f83426d1cdce7fe4f7f3913be1
URL:         http://cgit.haiku-os.org/haiku/commit/?id=6371cd4
Author:      François Revol <revol@free.fr>
Date:        Sat Mar 31 14:05:46 2012 UTC

Fix uninitialized warning.

----------------------------------------------------------------------------

diff --git a/src/servers/app/drawing/remote/RemoteMessage.h \
b/src/servers/app/drawing/remote/RemoteMessage.h index d2b6f0d..99968c5 100644
--- a/src/servers/app/drawing/remote/RemoteMessage.h
+++ b/src/servers/app/drawing/remote/RemoteMessage.h
@@ -227,7 +227,7 @@ RemoteMessage::Start(uint16 code)
 
 	Add(code);
 
-	uint32 sizeDummy;
+	uint32 sizeDummy = 0;
 	Add(sizeDummy);
 }
 

############################################################################

Revision:    hrev43916
Commit:      28b813df23ce0d5873dcf07a615685dfeae6b8ca
URL:         http://cgit.haiku-os.org/haiku/commit/?id=28b813d
Author:      François Revol <revol@free.fr>
Date:        Sat Mar 31 14:10:35 2012 UTC

Move callbackFunction type declaration into the class to avoid a name clash with \
future code.

----------------------------------------------------------------------------

diff --git a/src/servers/app/drawing/remote/RemoteHWInterface.cpp \
b/src/servers/app/drawing/remote/RemoteHWInterface.cpp index d14eabe..0084fa4 100644
--- a/src/servers/app/drawing/remote/RemoteHWInterface.cpp
+++ b/src/servers/app/drawing/remote/RemoteHWInterface.cpp
@@ -29,7 +29,7 @@
 
 struct callback_info {
 	uint32				token;
-	CallbackFunction	callback;
+	RemoteHWInterface::CallbackFunction	callback;
 	void*				cookie;
 };
 
diff --git a/src/servers/app/drawing/remote/RemoteHWInterface.h \
b/src/servers/app/drawing/remote/RemoteHWInterface.h index c196ecb..03fcad6 100644
--- a/src/servers/app/drawing/remote/RemoteHWInterface.h
+++ b/src/servers/app/drawing/remote/RemoteHWInterface.h
@@ -22,8 +22,6 @@ class RemoteMessage;
 
 struct callback_info;
 
-typedef bool (*CallbackFunction)(void* cookie, RemoteMessage& message);
-
 
 class RemoteHWInterface : public HWInterface {
 public:
@@ -81,6 +79,8 @@ virtual	status_t					CopyBackToFront(const BRect& frame);
 		StreamingRingBuffer*		ReceiveBuffer() { return fReceiveBuffer; }
 		StreamingRingBuffer*		SendBuffer() { return fSendBuffer; }
 
+typedef bool (*CallbackFunction)(void* cookie, RemoteMessage& message);
+
 		status_t					AddCallback(uint32 token,
 										CallbackFunction callback,
 										void* cookie);


[prev in list] [next in list] [prev in thread] [next in thread]