[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    [haiku-commits] Re: haiku: hrev43907 - src/preferences/screen
From:       Alexander von Gluck <kallisti5 () unixzen ! com>
Date:       2012-03-30 23:22:24
Message-ID: 198695a2068384cf9284844cc98835c9 () ssl ! unixzen ! com
[Download RAW message or body]

On 30.03.2012 17:19, anevilyak@gmail.com wrote:
> hrev43907 adds 1 changeset to branch 'master'
> old head: 1674a53a45f12befa208e7478337d811d1fed6fd
> new head: 7e44de362f7aa888dc01ed867de8815f600b7fd9
> 
> 
> ----------------------------------------------------------------------------
> 
> 7e44de3: Fix several issues in Screen preflet.
> 
> - Always initialize other menu item data member.
> - Always use refresh_rate_to_string() to generate item labels.
> - When searching for the item matching the selected refresh rate,
> look for it by the actual refresh rate stored in the item's message
> rather than by string comparisons of the label.
> - Don't assume the Other menu item exists, since it doesn't in cases
> where the refresh rate constraints only allow a single rate.
> - Update copyright year.
> 
> Fixes #8431.

Build failure.

C++ 
/Buildbot/slave/x86-debug-any-host/generated.x86gcc2-debug/objects/haiku/x86/debug_1/preferences/screen/ScreenWindow.o
                
cc1plus: warnings being treated as errors
/Buildbot/slave/haiku/src/preferences/screen/ScreenWindow.h: In method 
`ScreenWindow::ScreenWindow(ScreenSettings *)':
/Buildbot/slave/haiku/src/preferences/screen/ScreenWindow.h:88: warning: 
member initializers for `class BMenuItem * ScreenWindow::fOtherRefresh'
/Buildbot/slave/haiku/src/preferences/screen/ScreenWindow.h:105: warning:   
and `class ScreenMode ScreenWindow::fScreenMode'
/Buildbot/slave/haiku/src/preferences/screen/ScreenWindow.cpp:178: warning:  
will be re-ordered to match declaration order


[prev in list] [next in list] [prev in thread] [next in thread]