[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    Re: [Haiku-commits] r33375 - in haiku/trunk/src/preferences:
From:       Jérôme Duval <korli () users ! berlios ! de>
Date:       2009-09-30 21:27:37
Message-ID: c47b1d430909301427l71798b4dn160b28bd6d2cb55a () mail ! gmail ! com
[Download RAW message or body]

Hi,

2009/9/30 pulkomandy at BerliOS <pulkomandy@mail.berlios.de>:
> Modified: haiku/trunk/src/preferences/appearance/APRMain.h
> ===================================================================
> --- haiku/trunk/src/preferences/appearance/APRMain.h    2009-09-30 20:26:42 UTC (rev 33374)
> +++ haiku/trunk/src/preferences/appearance/APRMain.h    2009-09-30 21:03:20 UTC (rev 33375)
> @@ -20,6 +20,7 @@
>  private:
>
>        APRWindow *fWindow;
> +       BCatalog cat;
>  };

Isn't there a better way ? be_catalog could stay loaded and be
destroyed on exit. I would avoid such variable in every app.
Code style isn't good also, fCatalog would be better.

Bye,
Jérôme
_______________________________________________
Haiku-commits mailing list
Haiku-commits@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/haiku-commits

[prev in list] [next in list] [prev in thread] [next in thread]