[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-commits
Subject:    Re: [Haiku-commits] r30902 - in haiku/trunk/src:
From:       David McPaul <dlmcpaul () gmail ! com>
Date:       2009-05-30 0:45:25
Message-ID: da2be3d70905291745l40a49d5fq4e6379073b798f4c () mail ! gmail ! com
[Download RAW message or body]

2009/5/29 Ingo Weinhold <ingo_weinhold@gmx.de>:
>
> On 2009-05-29 at 11:23:08 [+0200], David McPaul <dlmcpaul@gmail.com> wrote:
>> 2009/5/29 Jérôme Duval <korli@users.berlios.de>:
>> > 2009/5/29 David McPaul <dlmcpaul@gmail.com>:
>> >>>>> > These changes are nonsensical. Please revert!
>> >>>
>> >>>>> Since we have Werror turned on for kernel code, GCC 4.4 will in turn
>> >>>>> cause an error when it comes across code that has non-void functions
>> >>>>> that don't return anything.
>> >>>
>> >>>> Oh my, I see. Is there any more reasonable alternative to inserting
>> >>>> dead code
>> >>>> to make gcc 4.4 happy? Like marking the functions "noreturn"?
>> >>
>> >> Why do we have non void functions that don't return anything?
>> >
>> > These functions aren't expected to ever return, and should live forever.
>>
>> So why not make them void?
>
> Those are functions for kernel threads. They have to have the signature
> required by spawn_kernel_thread().

Perhaps we can add a void version of spawn_kernel_thread.  Since we
have a use for such.

-- 
Cheers
David
_______________________________________________
Haiku-commits mailing list
Haiku-commits@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/haiku-commits

[prev in list] [next in list] [prev in thread] [next in thread]