[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-bugs
Subject:    [haiku-bugs] Re: [Haiku] #18820: [Terminal] HyperLink mode fails for paths with escaped chars.
From:       "Haiku" <trac () haiku-os ! org>
Date:       2024-02-28 14:54:04
Message-ID: 058.c5f264f1c84fe024b72dc0cd072fc646 () haiku-os ! org
[Download RAW message or body]

--===============7034074976899272975==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

#18820: [Terminal] HyperLink mode fails for paths with escaped chars.
------------------------------------+-------------------------
  Reporter:  bipolar                |      Owner:  jackburton
      Type:  bug                    |     Status:  new
  Priority:  normal                 |  Milestone:  Unscheduled
 Component:  Applications/Terminal  |    Version:  R1/beta4
Resolution:                         |   Keywords:
Blocked By:                         |   Blocking:
  Platform:  All                    |
------------------------------------+-------------------------
Comment (by bipolar):

 Thanks a bunch Adrien.

 I *had* tried adding '\', '[' and ']', but still wasn't getting proper
 matches on `_GetHyperlinkAt`.

 After closer inspection (and some coffee, and sweat, and tears :-D):

 Seems that introducing a classifier for absolute paths (instead of trying
 to re-use fCharClassifier :-D), and doing that `CharacterDeescape()`
 before `_EntryExists`, did the trick!

 Will do more testing/clean up, and submit a patch for review.

 Thanks again!
-- =

Ticket URL: <https://dev.haiku-os.org/ticket/18820#comment:2>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
--===============7034074976899272975==--

[prev in list] [next in list] [prev in thread] [next in thread]