[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-bugs
Subject:    [haiku-bugs] Re: [Haiku] #12262: Changes to User Agent to Include a Version of the Application
From:       "apl-haiku" <trac () haiku-os ! org>
Date:       2015-07-31 10:32:47
Message-ID: 060.5a0e73ac66d42ae6aecd0c1b5edcc90f () haiku-os ! org
[Download RAW message or body]

#12262: Changes to User Agent to Include a Version of the Application
---------------------------------------+----------------------------
   Reporter:  apl-haiku                |      Owner:  stippi
       Type:  enhancement              |     Status:  new
   Priority:  normal                   |  Milestone:  Unscheduled
  Component:  Applications/HaikuDepot  |    Version:  R1/Development
 Resolution:                           |   Keywords:
 Blocked By:                           |   Blocking:
Has a Patch:  1                        |   Platform:  All
---------------------------------------+----------------------------

Comment (by apl-haiku):

 I'm building the user agent string as a static member variable because the
 "WebAppInterface" is instantiated in more than one place in the
 application and I don't want it to be encumbered with the overhead of
 reading the application version each time.

 I've expanded the includes and added more checks for error states.  I've
 also re-arranged the code a bit to make the error handling less onerous
 around deriving the version string through early-exit.

 Patch re-attached.

--
Ticket URL: <https://dev.haiku-os.org/ticket/12262#comment:3>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

[prev in list] [next in list] [prev in thread] [next in thread]