[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-bugs
Subject:    [haiku-bugs] Re: [Haiku] #5615: Pairs is fixed at 4 tiles x 4 tiles,
From:       "stippi" <trac () haiku-os ! org>
Date:       2010-03-28 22:32:33
Message-ID: 051.244aa60437a92b4bb05d2eba6976aa89 () haiku-os ! org
[Download RAW message or body]

#5615: Pairs is fixed at 4 tiles x 4 tiles, add support for a different game sizes
(easy)
--------------------------+-------------------------------------------------
 Reporter:  scottmc       |       Owner:  nobody     
     Type:  enhancement   |      Status:  new        
 Priority:  normal        |   Milestone:  Unscheduled
Component:  Applications  |     Version:  R1/alpha1  
 Keywords:  gsoc2010      |   Blockedby:             
 Platform:  All           |    Blocking:             
--------------------------+-------------------------------------------------

Comment(by stippi):

 Hi adams,

 thanks for the patch, the implementation is adequate. Some things could be
 factored out into separate methods even more, like you've already started
 doing (for example I am sure the switch case you added in MessageReceived
 for switching board size will not even compile without warning). But the
 main issue with the patch is coding style. From the main website, you can
 go into the development section and the Getting Started section has a link
 to our coding style guide. We are pretty strict about applying it. :-) So
 if you read through that document and apply it to the code you added, I
 would be happy to apply your patch.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/5615#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.


[prev in list] [next in list] [prev in thread] [next in thread]