[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-bugs
Subject:    Re: [Haiku-bugs] [Haiku] #3980: [patch] Keyboard shortcut icon for
From:       "VinDuv" <trac () haiku-os ! org>
Date:       2009-05-30 21:11:16
Message-ID: 050.29c21281c8633b22b43aa511ce55fcac () haiku-os ! org
[Download RAW message or body]

#3980: [patch] Keyboard shortcut icon for Apple keyboards
--------------------------------+-------------------------------------------
 Reporter:  VinDuv              |       Owner:  axeld         
     Type:  enhancement         |      Status:  new           
 Priority:  normal              |   Milestone:  R1            
Component:  Kits/Interface Kit  |     Version:  R1 development
Blockedby:                      |    Platform:  All           
 Blocking:                      |  
--------------------------------+-------------------------------------------

Comment(by VinDuv):

 Replying to [comment:1 andreasf]:
 > Your patch introduces a potential {{{NULL}}} dereference of {{{keys}}}
 in {{{src/kits/interface/Menu.cpp}}}.
 Whoops, fixed ;)[[BR]]
 > I'm less certain why in presence of the command key the alt and ctrl
 alternatives - present on Apple keyboards, too - should be disallowed.
 I wasn't sure if it was really useful... Mac users are generally
 accustomed to using the Command key for keyboard shortcuts, so allow
 switching to Control is probably not needed.[[BR]]
 Anyway, I reactivated the button in this new patch and fixed the mode
 detection so it shows "Switch Shortcut Keys To Windows/Linux Mode" or
 "Switch Shortcut Keys To Haiku/Mac OS Mode" instead of just "Switch
 Shortcut Keys" for Apple keymaps.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/3980#comment:2>
Haiku <http://dev.haiku-os.org>
The Haiku operating system.
_______________________________________________
Haiku-bugs mailing list
Haiku-bugs@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/haiku-bugs

[prev in list] [next in list] [prev in thread] [next in thread]