[prev in list] [next in list] [prev in thread] [next in thread] 

List:       haiku-bugs
Subject:    Re: [Haiku-bugs] [Haiku] #3172: registrar creating huge amounts of
From:       "anevilyak" <trac () haiku-os ! org>
Date:       2008-11-29 23:35:37
Message-ID: 053.2d9f8377256929dea3aa6fddb83bd18c () haiku-os ! org
[Download RAW message or body]

#3172: registrar creating huge amounts of worker threads over time
--------------------------------+-------------------------------------------
  Reporter:  anevilyak          |       Owner:  bonefish      
      Type:  bug                |      Status:  new           
  Priority:  normal             |   Milestone:  R1            
 Component:  Servers/registrar  |     Version:  R1 development
Resolution:                     |   Blockedby:                
  Platform:  All                |    Blocking:                
--------------------------------+-------------------------------------------

Comment(by anevilyak):

 I think I might have found part of the problem... RegistrarThreadManager
 returns an error (B_NO_MORE_THREADS) if its thread counter is higher than
 12, though I'm uncertain as to why the threshold is so low. The problem
 is, in this case the thread has already been created by RegistrarThread's
 constructor, but it isn't subsequently resumed/killed by the d'tor or any
 other function in this case. My question is, is that thread limit even
 necessary? By the time it's checked the thread has already been spawned
 anyways, so I see no useful purpose to the limiter at that point, ignoring
 the fact that its cleanup logic is broken. Attached please find a diff
 that removes the check. Let me know if you see any issue with doing so.
 The one question I have is, without that check, all the code for tracking
 the thread count is more or less superfluous (and could probably be
 obtained from the STL container directly anyways), so would it be
 desirable to remove it?

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/3172#comment:2>
Haiku <http://dev.haiku-os.org>
The Haiku operating system.
_______________________________________________
Haiku-bugs mailing list
Haiku-bugs@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/haiku-bugs
[prev in list] [next in list] [prev in thread] [next in thread]