[prev in list] [next in list] [prev in thread] [next in thread] 

List:       hadoop-dev
Subject:    Re: What is the correct spelling?
From:       Todd Lipcon <todd () cloudera ! com>
Date:       2010-12-27 20:41:41
Message-ID: AANLkTimqOC5YQT1vX5R6cPwKv1h0H8pfTtO1A2gShV3C () mail ! gmail ! com
[Download RAW message or body]


Hi Niels,

Yep, I'd say for something like that it's fine t fix the spelling as part of
another patch that touches those functions.

-Todd

On Mon, Dec 27, 2010 at 1:18 AM, Niels Basjes <Niels@basjes.nl> wrote:

> Hi Todd,
> 
> > Unfortunately this is part of a public facing API, so it's a bit tough to
> > change without breaking a bunch of dependent code. So, I think despite
> the
> > annoying spelling mistake, it's not worth the pain to fix because of the
> API
> > breakage :(
> 
> Yes, I fully agree. Changing public APIs is a monster.
> 
> > If you find other spelling mistakes that are parts of internal APIs, feel
> > free to file JIRAs and patches to fix!
> 
> The changes I was thinking about are limited to the junit testing
> files for the codecs. --> fully internal
> 
> Specifically this one:
> 
> http://svn.apache.org/viewvc/hadoop/common/trunk/src/test/core/org/apache/hadoop/io/compress/TestCodec.java?view=markup
>  
> Which contains (among others) this method: testSplitableCodecs
> 
> As I'm actually touching these methods I'll include the changes in the
> patch I'm currently working on.
> 
> --
> Met vriendelijke groeten,
> 
> Niels Basjes
> 



-- 
Todd Lipcon
Software Engineer, Cloudera



[prev in list] [next in list] [prev in thread] [next in thread]