'Re: Review Request 125216: Fix reading the ui.rc and as a result fix the UI.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gwenview-devel
Subject:    Re: Review Request 125216: Fix reading the ui.rc and as a result fix the UI.
From:       Shlomi Fish <shlomif () shlomifish ! org>
Date:       2016-11-22 1:58:19
Message-ID: 20161122015819.32069.7631 () mimi ! kde ! org
[Download RAW message or body]

--===============7167979101065023238==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125216/
-----------------------------------------------------------

(Updated Nov. 22, 2016, 2:58 a.m.)


Status
------

This change has been discarded.


Review request for Gwenview and Ivan Čukić.


Repository: gwenview


Description
-------

Fix reading the ui.rc file - without it, most of the UI is missing.


Diffs
-----

  app/main.cpp 806fcab 

Diff: https://git.reviewboard.kde.org/r/125216/diff/


Testing
-------

See https://bugs.kde.org/show_bug.cgi?id=352622 - gwenview seems to run fine and much \
better with this patch. I tried running rotate, rescale and crop - all are working \
fine.


Thanks,

Shlomi Fish


--===============7167979101065023238==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125216/">https://git.reviewboard.kde.org/r/125216/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview and Ivan Čukić.</div>
<div>By Shlomi Fish.</div>


<p style="color: grey;"><i>Updated Nov. 22, 2016, 2:58 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix reading the ui.rc file - without it, most of the \
UI is missing.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See https://bugs.kde.org/show_bug.cgi?id=352622 - \
gwenview seems to run fine and much better with this patch. I tried running rotate, \
rescale and crop - all are working fine.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>app/main.cpp <span style="color: grey">(806fcab)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125216/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============7167979101065023238==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic