[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 129357: Bring back Gwenview importer
From: Christoph Feck <cfeck () kde ! org>
Date: 2016-11-10 23:32:27
Message-ID: 20161110233227.6207.74332 () mimi ! kde ! org
[Download RAW message or body]
--===============7038145571056621028==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Nov. 10, 2016, 2:52 p.m., Christoph Feck wrote:
> > importer/main.cpp, line 53
> > <https://git.reviewboard.kde.org/r/129357/diff/2/?file=484516#file484516line53>
> >
> > I think you need to instantiate QApplication before using i18n(), in other words, \
> > as your first action in main().
> > Also, some setTranslationDomain() call is needed before calling i18n.
>
> Aurélien Gâteau wrote:
> I moved the QApplication instantiation, but I am not sure what to do about \
> setTranslationDomain(): did you mean QApplication::setOrganizationDomain()?
KLocalizedString::setApplicationDomain()
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129357/#review100761
-----------------------------------------------------------
On Nov. 10, 2016, 11:54 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129357/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2016, 11:54 p.m.)
>
>
> Review request for Gwenview.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> This patch ports Gwenview importer to KF5, so one can import photos again. There \
> are no functional changes with the old KDE4 version, except for any regression I \
> could have missed.
>
> Diffs
> -----
>
> CMakeLists.txt 645d4348a9500e406589e52cd508794d6856c8f2
> importer/CMakeLists.txt 81e585c1e13ef22c84c92196754acb74a72862d5
> importer/dialogpage.cpp f7a8fbc611b5473466895759fe978a31d70a53bb
> importer/documentdirfinder.h 05b96236677426fd463ef6bfb8660a84fbf24522
> importer/documentdirfinder.cpp 76e7d1b753edbc04212b6efb68de888ea8532c7c
> importer/filenameformater.h f16409d303836e4ffaf223fceb315be30c8bdc9f
> importer/filenameformater.cpp f9c33ec1fc996aad041482075e35af592aa5b6a4
> importer/fileutils.h db10f56ead6fe9bcc9af384a6ef44aeee86bd29e
> importer/fileutils.cpp 35a22e0b90c06a16f178923fb94f77109f760524
> importer/gwenview_importer.desktop 2a9b68b9ba95ef532598be8d1831611b603a63fa
> importer/importdialog.h 4abe82fce185f30f651b8d89c783a6444ed9e9b6
> importer/importdialog.cpp 7c85f519d1cfb48858427db679a8eb387b0110c6
> importer/importer.h 3efa282696133d239c0bee2f205e08cdbda3a9e2
> importer/importer.cpp 0d849df9822fe850bef71be6e42becc8f3a50938
> importer/importerconfigdialog.cpp 999a49f456ff56316c0c02d22282a50fc04c9788
> importer/main.cpp edc7c8db2a2ce151afa18eeb0eb21c6d333a3bce
> importer/progresspage.h 1a5e84b573f5093ef04188eb73d2220d17300e77
> importer/serializedurlmap.h b50927e401d87e0a360199244c9609aa37ede507
> importer/serializedurlmap.cpp 4127071d6bee4952cc91a11c2a42ee0da0105008
> importer/thumbnailpage.h 95d500662bd36d9201b50394ce3c49d29d859828
> importer/thumbnailpage.cpp 5032ca264ae7d20046b98767332346b3fdf84ef0
>
> Diff: https://git.reviewboard.kde.org/r/129357/diff/
>
>
> Testing
> -------
>
> Imported photos and videos from SD card and from dirs on my hd. Works fine.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
--===============7038145571056621028==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129357/">https://git.reviewboard.kde.org/r/129357/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 10th, 2016, 2:52 p.m. CET, \
<b>Christoph Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129357/diff/2/?file=484516#file484516line53" \
style="color: black; font-weight: bold; text-decoration: \
underline;">importer/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">48</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KCmdLineOptions</span> <span class="n">options</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">47</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QApplication</span> <span \
class="n">app</span><span class="p">(</span><span class="n">argc</span><span \
class="p">,</span> <span class="n">argv</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you need to \
instantiate QApplication before using i18n(), in other words, as your first action in \
main().
Also, some setTranslationDomain() call is needed before calling i18n.</pre>
</blockquote>
<p>On November 11th, 2016, 12:01 a.m. CET, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
moved the QApplication instantiation, but I am not sure what to do about \
setTranslationDomain(): did you mean QApplication::setOrganizationDomain()?</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KLocalizedString::setApplicationDomain()</pre> <br />
<p>- Christoph</p>
<br />
<p>On November 10th, 2016, 11:54 p.m. CET, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Gwenview.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2016, 11:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch ports Gwenview importer to KF5, so one can \
import photos again. There are no functional changes with the old KDE4 version, \
except for any regression I could have missed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Imported photos and videos from SD card and from dirs \
on my hd. Works fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(645d4348a9500e406589e52cd508794d6856c8f2)</span></li>
<li>importer/CMakeLists.txt <span style="color: \
grey">(81e585c1e13ef22c84c92196754acb74a72862d5)</span></li>
<li>importer/dialogpage.cpp <span style="color: \
grey">(f7a8fbc611b5473466895759fe978a31d70a53bb)</span></li>
<li>importer/documentdirfinder.h <span style="color: \
grey">(05b96236677426fd463ef6bfb8660a84fbf24522)</span></li>
<li>importer/documentdirfinder.cpp <span style="color: \
grey">(76e7d1b753edbc04212b6efb68de888ea8532c7c)</span></li>
<li>importer/filenameformater.h <span style="color: \
grey">(f16409d303836e4ffaf223fceb315be30c8bdc9f)</span></li>
<li>importer/filenameformater.cpp <span style="color: \
grey">(f9c33ec1fc996aad041482075e35af592aa5b6a4)</span></li>
<li>importer/fileutils.h <span style="color: \
grey">(db10f56ead6fe9bcc9af384a6ef44aeee86bd29e)</span></li>
<li>importer/fileutils.cpp <span style="color: \
grey">(35a22e0b90c06a16f178923fb94f77109f760524)</span></li>
<li>importer/gwenview_importer.desktop <span style="color: \
grey">(2a9b68b9ba95ef532598be8d1831611b603a63fa)</span></li>
<li>importer/importdialog.h <span style="color: \
grey">(4abe82fce185f30f651b8d89c783a6444ed9e9b6)</span></li>
<li>importer/importdialog.cpp <span style="color: \
grey">(7c85f519d1cfb48858427db679a8eb387b0110c6)</span></li>
<li>importer/importer.h <span style="color: \
grey">(3efa282696133d239c0bee2f205e08cdbda3a9e2)</span></li>
<li>importer/importer.cpp <span style="color: \
grey">(0d849df9822fe850bef71be6e42becc8f3a50938)</span></li>
<li>importer/importerconfigdialog.cpp <span style="color: \
grey">(999a49f456ff56316c0c02d22282a50fc04c9788)</span></li>
<li>importer/main.cpp <span style="color: \
grey">(edc7c8db2a2ce151afa18eeb0eb21c6d333a3bce)</span></li>
<li>importer/progresspage.h <span style="color: \
grey">(1a5e84b573f5093ef04188eb73d2220d17300e77)</span></li>
<li>importer/serializedurlmap.h <span style="color: \
grey">(b50927e401d87e0a360199244c9609aa37ede507)</span></li>
<li>importer/serializedurlmap.cpp <span style="color: \
grey">(4127071d6bee4952cc91a11c2a42ee0da0105008)</span></li>
<li>importer/thumbnailpage.h <span style="color: \
grey">(95d500662bd36d9201b50394ce3c49d29d859828)</span></li>
<li>importer/thumbnailpage.cpp <span style="color: \
grey">(5032ca264ae7d20046b98767332346b3fdf84ef0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129357/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7038145571056621028==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic